Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Fix: Stop recursion at workspace folder boundary to prevent root folder error #669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 3 commits into
base: main
Choose a base branch
Loading
from
Draft

Fix: Stop recursion at workspace folder boundary to prevent root folder error #669

wants to merge 3 commits into from

Conversation

Copilot
Copy link
Contributor

@Copilot Copilot AI commented Oct 12, 2025 •
edited
Loading

Problem

The extension throws a fatal error when discovering test files in workspaces with deeply nested directory structures:

Error: Fatal Error: Attempted to get parent of root folder "/"

This occurs in monorepo structures and projects with many nested folders (like the BlockNote repository), where the extension attempts to create test items for files deep within the workspace hierarchy.

Root Cause

The getOrCreateFolderTestItem method recursively creates parent folder test items to build the folder hierarchy in the test explorer. However, it lacked a workspace folder boundary check, causing the recursion to continue beyond the workspace folder all the way to the filesystem root /. When it reaches the root, dirname("/") returns "/" itself, triggering the error condition.

Example flow in a monorepo:

File: /workspace/packages/core/tests/test.ts
  → Create folder: /workspace/packages/core/tests
    → Create folder: /workspace/packages/core
      → Create folder: /workspace/packages
        → Create folder: /workspace  ✓ (should stop here at workspace boundary)
          → Create folder: /
            → dirname("/") = "/"
            → ERROR: "Attempted to get parent of root folder"

Solution

Added a workspace folder boundary check in getOrCreateFolderTestItem that stops recursion when it reaches the workspace folder. The method now:

  1. Checks the cache for an existing folder item
  2. NEW: Checks if the current folder is the workspace folder - if so, returns the workspace folder item
  3. Otherwise, recursively creates the parent folder

This ensures folder item creation stops at the workspace boundary rather than continuing to the filesystem root.

Changes

  • packages/extension/src/testTree.ts: Added 14 lines to check workspace folder boundary before recursion
  • test/unit/testTree.test.ts: Added 80 lines of documentation tests explaining the fix and expected behavior

Testing

✅ TypeScript compilation passes
✅ ESLint passes
✅ Build succeeds
✅ Logic verified for edge cases:

  • Files directly in workspace folder
  • Files in deeply nested directories
  • Multiple workspace folders
  • Symlinked folders (paths are normalized)

Impact

This fix resolves crashes when working with:

  • Monorepo structures with many nested packages
  • Projects with deep directory hierarchies
  • Any workspace where test files are not at the workspace root

Fixes #XXX (replace with issue number)

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • update.code.visualstudio.com
    • Triggering command: node /home/REDACTED/work/vscode/vscode/node_modules/.bin/../@vscode/test-cli/out/bin.mjs (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Original prompt

This section details on the original issue you should resolve

<issue_title>Error: Attempted to get parent of root folder "/"</issue_title>
<issue_description>### Describe the bug

I keep getting failures of it looking up directories when starting the vitest extension in VS Code.

Reproduction

https://github.com/TypeCellOS/BlockNote/

Output

[INFO 9:34:39 AM] [v0.0.0] Vitest extension is activated because Vitest is installed or there is a Vite/Vitest config file in the workspace.
[INFO 9:34:40 AM] [API] Resolving workspace configs: vitest.workspace.ts
[INFO 9:34:41 AM] [TERMINAL] Initiated ws connection via ws://localhost:57840
[INFO 9:34:41 AM] [TERMINAL] Starting Vitest v2.1.9 (blockNote/vitest.workspace.ts) in the terminal: node /Users/nickthesick/.cursor/extensions/vitest.explorer-1.28.2-universal/dist/worker.js;
[INFO 9:34:41 AM] [TERMINAL] Shell integration is initiated.
[INFO 9:34:42 AM] [API] Vitest v2.1.9 (blockNote/vitest.workspace.ts) terminal process 65980 created
[INFO 9:34:42 AM] [API] Resolving configs: tests/vite.config.ts, playground/vite.config.ts, xl-pdf-exporter/vite.config.ts, mantine/vite.config.ts, xl-docx-exporter/vite.config.ts, code-block/vite.config.ts, ariakit/vite.config.ts, react/vite.config.ts, server-util/vite.config.ts, xl-ai-server/vite.config.ts, xl-ai/vite.config.ts, core/vite.config.ts, core/vite.config.bundled.ts, shadcn/vite.config.ts, xl-email-exporter/vite.config.ts, xl-multi-column/vite.config.ts, xl-odt-exporter/vite.config.ts, 01-ui-elements-remove/vite.config.ts, 17-advanced-tables-2/vite.config.ts, 12-static-formatting-toolbar/vite.config.ts, 03-formatting-toolbar-block-type-items/vite.config.ts, 07-suggestion-menus-slash-menu-component/vite.config.ts, 01-tiptap-arrow-conversion/vite.config.ts, 07-converting-blocks-to-odt/vite.config.ts, 06-converting-blocks-to-docx/vite.config.ts, 11-uppy-file-panel/vite.config.ts, 10-suggestion-menus-grid-mentions/vite.config.ts, 08-converting-blocks-to-react-email/vite.config.ts, 15-advanced-tables/vite.config.ts, 08-suggestion-menus-emoji-picker-columns/vite.config.ts, 01-converting-blocks-to-html/vite.config.ts, 09-suggestion-menus-emoji-picker-component/vite.config.ts, 02-formatting-toolbar-buttons/vite.config.ts, 05-converting-blocks-to-pdf/vite.config.ts, 04-converting-blocks-from-md/vite.config.ts, 02-converting-blocks-from-html/vite.config.ts, 03-converting-blocks-to-md/vite.config.ts, react-custom-blocks/vite.config.ts, draggable-inline-content/vite.config.ts, 04-pdf-file-block/vite.config.ts, 06-toggleable-blocks/vite.config.ts, 03-font-style/vite.config.ts, react-custom-styles/vite.config.ts, react-custom-inline-content/vite.config.ts, 02-suggestion-menus-mentions/vite.config.ts, 01-alert-block/vite.config.ts, 05-alert-block-full-ux/vite.config.ts, 02-liveblocks/vite.config.ts, 05-comments-with-sidebar/vite.config.ts, 01-partykit/vite.config.ts, 03-y-sweet/vite.config.ts, 04-comments/vite.config.ts, 06-ghost-writer/vite.config.ts, 14-experimental-mobile-formatting-toolbar/vite.config.ts, 07-forking/vite.config.ts, 05-side-menu-drag-handle-items/vite.config.ts, 01-minimal/vite.config.ts, 16-link-toolbar-buttons/vite.config.ts, 04-with-collaboration/vite.config.ts, 04-side-menu-buttons/vite.config.ts, 13-custom-ui/vite.config.ts, 06-suggestion-menus-slash-menu-items/vite.config.ts, 03-custom-ai-menu-items/vite.config.ts, 02-playground/vite.config.ts, 01-theming-dom-attributes/vite.config.ts, 06-code-block/vite.config.ts, 02-changing-font/vite.config.ts, 05-removing-default-blocks/vite.config.ts, 13-custom-paste-handler/vite.config.ts, testing/vite.config.ts, 09-shadcn/vite.config.ts, 11-custom-placeholder/vite.config.ts, 03-multi-column/vite.config.ts, 07-custom-code-block/vite.config.ts, 02-block-objects/vite.config.ts, 03-theming-css/vite.config.ts, 06-block-manipulation/vite.config.ts, 05-theming-css-variables-code/vite.config.ts, 12-multi-editor/vite.config.ts, 01-minimal/vite.config.ts, 08-ariakit/vite.config.ts, 07-selection-blocks/vite.config.ts, 04-theming-css-variables/vite.config.ts, react-vanilla-custom-inline-content/vite.config.ts, react-vanilla-custom-styles/vite.config.ts, react-vanilla-custom-blocks/vite.config.ts, 01-file-uploading/vite.config.ts, 04-rendering-static-documents/vite.config.ts, 02-saving-loading/vite.config.ts, 03-s3/vite.config.ts, 04-default-blocks/vite.config.ts, 10-localization/vite.config.ts
[INFO 9:34:42 AM] [API] Ignoring config tests/vite.config.ts because there is a workspace config in the parent folder
[INFO 9:34:42 AM] [API] Ignoring config playground/vite.config.ts because there is a workspace config in the parent folder
[INFO 9:34:42 AM] [API] Ignoring config xl-pdf-exporter/vite.config.ts because there is a workspace config in the parent folder
[INFO 9:34:42 AM] [API] Ignoring config mantine/vite.config.ts because there is a workspace config in the parent folder
[INFO 9:34:42 AM] [API] Ignoring config xl-docx-exporter/vite.config.ts because t...

</details>

Fixes vitest-dev/vscode#657

<!-- START COPILOT CODING AGENT TIPS -->
---

💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click [here](https://survey3.medallia.com/?EAHeSx-AP01bZqG0Ld9QLQ) to start the survey.

Copilot AI and others added 2 commits October 12, 2025 13:34
@Copilot @sheremet-va
Fix: Stop recursion at workspace folder boundary in getOrCreateFolder…
708781e 
…TestItem

Co-authored-by: sheremet-va <16173870+sheremet-va@users.noreply.github.com>
@Copilot @sheremet-va
Add documentation tests for workspace folder boundary fix
ca7d514 
Co-authored-by: sheremet-va <16173870+sheremet-va@users.noreply.github.com>
@Copilot Copilot AI changed the title [WIP] Fix error when starting Vitest extension in VS Code Fix: Stop recursion at workspace folder boundary to prevent root folder error Oct 12, 2025
@Copilot Copilot AI requested a review from sheremet-va October 12, 2025 13:39
Copilot finished work on behalf of sheremet-va October 12, 2025 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sheremet-va sheremet-va Awaiting requested review from sheremet-va

At least 1 approving review is required to merge this pull request.

Assignees

@sheremet-va sheremet-va

Copilot code review Copilot

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Copilot @sheremet-va
Morty Proxy This is a proxified and sanitized view of the page, visit original site.