Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

refactor!: bump required node version to 20.19+, 22.12+ and drop CJS build #596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jun 5, 2025
Merged

refactor!: bump required node version to 20.19+, 22.12+ and drop CJS build #596

merged 5 commits into from
Jun 5, 2025

Conversation

sapphi-red
Copy link
Member

@sapphi-red sapphi-red commented Jun 5, 2025 •
edited
Loading

Description

This PR bumps required node version to 20.19+, 22.12+ and drops CJS build.

The pnpm dev script is broken due to unjs/unbuild#533. But I think this isn't a blocker for this PR.

close #595

Additional context

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Jun 5, 2025 •
edited
Loading

Open in StackBlitz

npm i https://pkg.pr.new/@vitejs/plugin-vue@596

npm i https://pkg.pr.new/@vitejs/plugin-vue-jsx@596

commit: bb2ab7d

@sapphi-red sapphi-red requested a review from sxzz June 5, 2025 05:41
sxzz
sxzz reviewed Jun 5, 2025
View reviewed changes
packages/plugin-vue-jsx/package.json Outdated Show resolved Hide resolved
packages/plugin-vue/package.json Outdated Show resolved Hide resolved
@sxzz sxzz merged commit 56df545 into main Jun 5, 2025
12 checks passed
@sxzz sxzz deleted the refactor/drop-node-18 branch June 5, 2025 09:48
@sxzz
Copy link
Member

sxzz commented Jun 5, 2025

Once Vite 7 is stable, we can get rid of alpha/beta version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sxzz sxzz sxzz approved these changes

Assignees
No one assigned
Labels
p1-chore 🧹
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

v6 release
2 participants
@sapphi-red @sxzz
Morty Proxy This is a proxified and sanitized view of the page, visit original site.