Handle both mouse wheel and trackpad #1972
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looking forward to this improvement! |
|
@Thomaash could you take a look at this PR? Having a fix for this would let us remove a very clunky workaround in our app where we have to give the user a setting to tell us which input device they're using. |
The current code ignores magnitude differences in deltaY, resulting in an experience that is either too fast on trackpad or too slow with a mousewheel. This change allows those to differ within a clamped range, so that one zoomSpeed value works well for both input devices. Fixes visjs#1882
Otherwise, right-to-left horizontal edges with middle-aligned labels would have their labels rendered at the origin.
This makes the actual problems in the code easier to find
|
+++ on this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current code ignores magnitude differences in deltaY, resulting in an experience that is either too fast on trackpad or too slow with a mousewheel.
This change allows those to differ within a clamped range, so that one zoomSpeed value works well for both input devices.
Fixes #1882