fix(x-search): retry on HTTP 429 using Retry-After or X-Rate-Limit-Reset#247
Open
fuleinist wants to merge 1 commit intovirattt:mainvirattt/dexter:mainfrom
fuleinist:fix/x-search-429-retryfuleinist/dexter:fix/x-search-429-retryCopy head branch name to clipboard
Open
fix(x-search): retry on HTTP 429 using Retry-After or X-Rate-Limit-Reset#247fuleinist wants to merge 1 commit intovirattt:mainvirattt/dexter:mainfrom fuleinist:fix/x-search-429-retryfuleinist/dexter:fix/x-search-429-retryCopy head branch name to clipboard
fuleinist wants to merge 1 commit intovirattt:mainvirattt/dexter:mainfrom
fuleinist:fix/x-search-429-retryfuleinist/dexter:fix/x-search-429-retryCopy head branch name to clipboard
Conversation
Before: 429 response threw immediately, losing multi-page search progress. After: 429 triggers retry after waiting for reset time. Honours Retry-After header when present; falls back to X-Rate-Limit-Reset; defaults to 60s. Preserves pagination state — only the rate-limited request is retried, not the entire search run.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: x-search.ts retries on HTTP 429 instead of aborting
Issue: #246
Problem
Multi-page X searches aborted mid-run when the API returned HTTP 429. The code read
X-Rate-Limit-Resetbut still threw immediately, losing all progress.Fix
xApiGet()now retries once after waiting for reset:Only the rate-limited request is retried — pagination state is preserved so multi-page search resumes from the next page after the wait.
Verification
npm testpasses (existing test suite).