fix(memory): avoid Bun Windows EEXIST on startup memory dir mkdir#243
Draft
virattt wants to merge 1 commit intomainvirattt/dexter:mainfrom
cursor/fix-memory-mkdir-windows-e23cvirattt/dexter:cursor/fix-memory-mkdir-windows-e23cCopy head branch name to clipboard
Draft
fix(memory): avoid Bun Windows EEXIST on startup memory dir mkdir#243virattt wants to merge 1 commit intomainvirattt/dexter:mainfrom cursor/fix-memory-mkdir-windows-e23cvirattt/dexter:cursor/fix-memory-mkdir-windows-e23cCopy head branch name to clipboard
virattt wants to merge 1 commit intomainvirattt/dexter:mainfrom
cursor/fix-memory-mkdir-windows-e23cvirattt/dexter:cursor/fix-memory-mkdir-windows-e23cCopy head branch name to clipboard
Conversation
Co-authored-by: Virat Singh <virattt@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ensureDirectory()helper that safely handles Bun-on-Windowsmkdir(..., { recursive: true })throwingEEXISTfor already-existing directoriesMemoryStore.ensureDirectoryExists()MemoryStore.writeMemoryFile()parent directory creationMemoryDatabase.create()parent directory creationensureDirectory()behavior when target already exists, is missing, and is a fileWhy
Issue #242 reports:
Error: EEXIST: file already exists, mkdir '.dexter\\memory'Dexter currently calls recursive mkdir on startup for
.dexter/memory. On affected Bun/Windows versions, this can throwEEXISTeven when the directory already exists, causing memory initialization to fail before the existing fallback handling.Validation
bun run typecheck/bun testin this cloud environment becausebunis not installed (bun: command not found)Risk
Low. Changes are limited to directory creation behavior and preserve existing failure semantics for non-directory collisions.