Add constructor with ToastType only #993
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check failure looks unrelated to my changes. I believe it's caused by this error: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a constructor for
ToastMessagethat takesToastTypeonly.With the new
RenderFragmenttoast content a constructor that takesToastTypebut not a string message now makes sense.At the same time make some changes to other constructors:
o Invoke simpler constructors from more complex ones to avoid duplicating code
o Use default argument for
autoHideinstead of writing two separate constructorso Add
autoHideparameter to constructor that takesIconNameto mirror the constructor that takescustomIconName