Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Accessibility enhancements #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 25, 2023
Merged

Accessibility enhancements #22

merged 1 commit into from
Mar 25, 2023

Conversation

tywayne
Copy link
Contributor

@tywayne tywayne commented Mar 25, 2023

  • Re-instate default browser outline styles on focus of elements. Setting outline: none without alternative styling to visually indicate a focus state makes keyboard navigation cumbersome.
  • set decorative SVG icons to aria-hidden="true"
  • better focus management for video in modal when opened
  • remove looping preview video from tab flow since it is not actionable
  • add descriptive text to media
  • add descriptive text to video modal trigger button

@vercel
Copy link

vercel bot commented Mar 25, 2023

@tywayne is attempting to deploy a commit to the Vercel Labs Team on Vercel.

A member of the Team first needs to authorize it.

@vercel
Copy link

vercel bot commented Mar 25, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
slacker ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 25, 2023 at 11:06PM (UTC)

leerob
leerob approved these changes Mar 25, 2023
View reviewed changes
Copy link
Collaborator

@leerob leerob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much!

@leerob leerob merged commit 0138da4 into vercel-labs:main Mar 25, 2023
@tywayne tywayne deleted the fix/a11y-issues branch March 25, 2023 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leerob leerob leerob approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tywayne @leerob
Morty Proxy This is a proxified and sanitized view of the page, visit original site.