ODA: intuitive default ordered direction + README#21
Merged
mytkom merged 3 commits intomasterventcode/orderable:masterfrom Jun 28, 2023
ODA-README-update-and-intuitive-orderingventcode/orderable:ODA-README-update-and-intuitive-orderingCopy head branch name to clipboard
Merged
ODA: intuitive default ordered direction + README#21mytkom merged 3 commits intomasterventcode/orderable:masterfrom ODA-README-update-and-intuitive-orderingventcode/orderable:ODA-README-update-and-intuitive-orderingCopy head branch name to clipboard
mytkom merged 3 commits intomasterventcode/orderable:masterfrom
ODA-README-update-and-intuitive-orderingventcode/orderable:ODA-README-update-and-intuitive-orderingCopy head branch name to clipboard
Conversation
mattlata
reviewed
Jun 28, 2023
mattlata
reviewed
Jun 28, 2023
mattlata
reviewed
Jun 28, 2023
mattlata
reviewed
Jun 28, 2023
mattlata
approved these changes
Jun 28, 2023
mattlata
reviewed
Jun 28, 2023
mattlata
reviewed
Jun 28, 2023
mattlata
approved these changes
Jun 28, 2023
e59aa12 to
164712b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Like rodzena said: It don't feel intuitive for
orderedscope without argument to sort by descending positioning field. Since we have provided sequenceincremental/decrementalandauto_setoptions, it is imo a good idea to don't change scope's default direction. Then incremental sequence + auto_set would mean default_push_back and decremental + auto_set would mean default_push_front. This solution provides more possibilities in comparision to current implementation, where it is always default_push_front.