Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Update subprocess types and improve error handling in run.py #485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 22, 2025
Merged

Update subprocess types and improve error handling in run.py #485

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
80b480e
refactor(run) Refactor to unicode only (`text=True`)
tony Feb 22, 2025
32b43ea
chore(subprocess) Fix ruff issues
tony Feb 22, 2025
d4015ff
docs(CHANGES) Note `run()` update
tony Feb 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
docs(CHANGES) Note run() update
  • Loading branch information
@tony
tony committed Feb 22, 2025
commit d4015ff3ea9131f0f6851cf3bc46ca64d44facb8
8 changes: 8 additions & 0 deletions 8 CHANGES
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,14 @@ $ pip install --user --upgrade --pre libvcs

<!-- Maintainers, insert changes / features for the next release here -->

### Breaking changes

#### `run()` now uses `text=True` (#485)

This means that unicode, not bytes, will be used for running `subprocess`
commands in libvcs. If there are any compatibility issues with this, please file
a ticket.

### Development

#### chore: Implement PEP 563 deferred annotation resolution (#483)
Expand Down
Morty Proxy This is a proxified and sanitized view of the page, visit original site.