-x json parameter #4378
Open
-x json parameter #4378
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dridi
reviewed
Aug 20, 2025
There was a problem hiding this comment.
We now have an alternative to the VJSN API and hand-rolled JSON, could you please give it a try?
It's used in several places, and vbor.h tries to describe how the APIs work. Having someone other than @daghf (who reviewed it) giving it a try would be a good benchmark for its usability.
If the docs in vbor.h and examples from other places are not enough, then please complain in my general direction.
|
Never mind my comment, I was certain this was a change you wanted to make in varnish enterprise. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been thinking that it would be pretty nice to have shell completion for
varnishd, but the parameter part is a bit unwieldy because to discover all the parameters, one would need to parse thevarnishd -x parameteroutput, which isn't fun.So, I brute-forced a
-x parameter-jsonimplementation to gauge interest in implementing this.If we do want to do this, I'm make sure we have tests before we merge, but the actual completion scripts can/should be worried about later