QoL improvements to release notes script/notebooks#626
QoL improvements to release notes script/notebooks#626validbeck merged 25 commits intomainvalidmind/documentation:mainfrom beck/sc-8017/release-notes-scripts-notebooks-qol-improvementsvalidmind/documentation:beck/sc-8017/release-notes-scripts-notebooks-qol-improvementsCopy head branch name to clipboard
Conversation
|
A PR preview is available: Preview URL |
|
A PR preview is available: Preview URL |
1 similar comment
|
A PR preview is available: Preview URL |
|
A PR preview is available: Preview URL |
2 similar comments
|
A PR preview is available: Preview URL |
|
A PR preview is available: Preview URL |
8bd1379 to
10e317a
Compare
|
A PR preview is available: Preview URL |
1468878 to
10e317a
Compare
PR SummaryThis pull request introduces several enhancements to the release note generation and yearly cleanup scripts. The key changes include:
These changes aim to improve the organization and accessibility of release notes while simplifying the yearly cleanup process. Test Suggestions
|
|
A PR preview is available: Preview URL |
nrichers
left a comment
There was a problem hiding this comment.
Tested this PR locally and it works a treat — it's quite impressive to simply enter a few prompts and have the release notes pop up in a preview a little while later. Feels polished. The aliases are a nice touch. ✨✨✨
Just a quick update to update_quarto_yaml() (adding the new yearly accordion to the sidebar) to accommodate for the releases already being in the yearly folder rather than fixing the filepaths after we move the files
I wouldn't make any changes to this PR, but since we now list the latest releases on the home page, it feels like even the sidebar could just use the year folder from the start, rather than breaking out the current releases one heading level higher — I could see a future where we retire release-scripts/year-end-cleanup.ipynb altogether because everything is already where it needs to be and whatever else needs to be done gets handled by the release notes script itself.
Nicely done, @validbeck! Great QoL improvements.
* Add make execute PROFILE=exe-prod to docs-site action (#598) * Add execute PROFILE=exe-prod to Docker image build * Move notebook execution into docs-site action * Docs — Customize model overview page (#622) * Draft customize-model-overview-page.qmd * Quick instructions * Edits based on feedback from Rod * Updated docs — Workflows (#620) * Tweak to release generation notebook * Wait, gotta make the file first * Wording in notebook * Just being picky about spaces now * Adding open file to yearly_cleanup.py too * Success * Edits to customize-model-lifecycle-statuses.qmd * New img - working-with-model-workflows.qmd > See workflow statuses * +reset-workflow.gif to working-with-model-workflows.qmd * Updated set-up-model-workflows.qmd > Configure workflow steps * Updated configure-user-action.png * Updated approval-group-setup.png * Redid the Approval Step example/images * Redid the Condition Branch example/images * Changed linked-workflow image to a gif * Updated set-up-model-workflows.qmd > Link approval steps * Changed my mind about the model-workflows.png screencap * Tweak * Simplifying based on Rod's suggestion * QoL improvements to release notes script/notebooks (#626) * Testing adding the year to generated release notes * oops, forgot to parse the date format * Now the folder is swapped ugh * Adding the year to the _quarto.yml entry * Oops, forgot to add the input * Casing * Adding new year folder to index function * Grabbing yearly folders in established year * Fake 2025 releases for testing & modifying Makefile command * Fake 2026 release for yearly cleanup test * Trying the yearly lookup again * Yearly lookup works * Retrieve year folder * Commenting out move releases for now * Removed move releases * Modifying update_quarto_yaml * Cleaning up the Makefile command * Notebook wording cleanup * Removing test files & reverting _quarto.yml & index.qmd to main * Added aliases for moved 2024 releases * Added aliases for moved 2023 releases * Whoops, wrong alias for some of the super old releases * Nitpicky edit * Meh * Nitpicking the output * Added instructions for Wait steps in workflows (#628) * Edits to date & date-time custom fields * Wait step draft * Edits & footnotes --------- Co-authored-by: Nik Richers <nik@validmind.ai> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Internal Notes for Reviewers
Aliases added to older moved releases
What the header says — 2023 & 2024 releases have aliases now so that their old URLs resolve to the new ones where they got moved after the old year-end cleanup process.
Test the redirects
/releases/2024-dec-24/release-notes.html>/releases/2024/2024-dec-24/release-notes.htmlQuality of life improvements for release notes process
Generate release notes
create_release_folder()🎉update_quarto_yaml()(inserting the new releases page into the sidebar) andupdate_index_qmd()(adding the latest release to the index and removing the oldest one from the listing) now also use the new filepath with the format{year}/{year}-mon-00/release-notes.qmdso those files update correctly without adjustmentYear-end release cleanup
Since generating the release notes now creates the releases automatically in a yearly folder:
create_year_folder()>retrieve_year_folder()move_yearly_releases()update_quarto_yaml()(adding the new yearly accordion to the sidebar) to accommodate for the releases already being in the yearly folder rather than fixing the filepaths after we move the filesupdate_paths(),search_links()Try it yourself
gh pr checkout 626Creating the test release notes
Before we can test the year-end release cleanup, we'll need to create two sets of test release notes: 2 from 2025 and 1 from 2026.
release-scripts/generate-release-notes.ipynband run the notebook with any release tag of your choice (I just used https://github.com/validmind/documentation/releases/tag/v2.6.7 for all the testing). Leave the date as default for this run. Your preview should show:index.qmdunderLatest Releasesand the oldest one from the listing removedReleasessidebar and have the filepath:releases/{year}/{year}-mon-00/release-notes.htmlsite/folder:cd sitemake release-notes. You can use the same release tag but PICK A DIFFERENT DATE THAT IS IN 2025 THAT ISN'T THE DEFAULT. This is important because we want two "release notes" in 2025 to work with. Your preview should show:index.qmdunderLatest Releasesto the left of the previous one you just addedReleasessidebar on top of the previous one you just addedCleaning up the "2025" releases
Cool, now that we have releases to clean up:
release-scripts/year-end-cleanup.ipynband run the notebook, ENTERING IN2025WHEN PROMPTED (DO NOT LEAVE DEFAULT AS THIS WILL PULL 2024). You should see:_quarto.ymlsidebar & comment markers