Docs quick audit — ValidMind Library#593
Docs quick audit — ValidMind Library#593validbeck merged 10 commits intomainvalidmind/documentation:mainfrom beck/sc-6526/docs-audit-p3-developer-frameworkvalidmind/documentation:beck/sc-6526/docs-audit-p3-developer-frameworkCopy head branch name to clipboard
Conversation
PR SummaryThis pull request introduces several enhancements to the ValidMind documentation and user interface. Key changes include:
These changes aim to improve the overall user experience and accessibility of the ValidMind documentation, making it easier for developers to navigate and utilize the resources provided. Test Suggestions
|
nrichers
left a comment
There was a problem hiding this comment.
This generally looks fine and very reasonable but there are two changes that I am not sure add value and would omit:
-
The two-column layout for supported models looks messier than the original, what with misaligned lines, and the layout generally makes it harder to read the content, IMHO.
I'm pretty sure I tried a similar layout before and decided it just wasn't worth it. You'd have to go to a more rectilinear
.featurelayout similar to what we did for the LLM docs for this to work, I think, or revert to the original layout. -
We can improve this page but adding buttons on the right that simply repeat what's already on the left seems quite superfluous?
I could see the left sidebar matching the headings of these sections better — e.g. "Run tests & test suites" → "Learn how to run tests" — and skip the buttons.
Note that our own style guidelines recommend only linking to specific items, not to use them as a substitute for navigation:
Sometimes, it’s helpful to highlight a call to action with a button that takes you to a topic or to a notebook on JupyterHub.
|
A PR preview is available: Preview URL |
There was a problem hiding this comment.
EDIT: Also a reminder that this page is going to get entirely revamped in our upcoming reshuffle — so can we just deal with it then instead of quibbling about the minor details now?
The latest preview looks clean enough, LGTM. ![]()
EDIT: As in, let's defer the other discussions until later, e.g. around renaming sidebar text to match section headings.
Would you believe that that was my first version of this and I reverted it because I thought "Nik will make me remove it"? 🫠
I actually like the benefits of .feature but I would simplify it it a bit in the future, similar to how we ended up using a simplified layout for the support ticket options. 😬




Internal Notes for Reviewers
Documentation drop-down icon
Realised I used the same icon for "Guides" and "About" when I fixed this, so:
ValidMind Library portal
LIVE PREVIEW
Just some quick visual cleanup, made sure any images had alt-text & captions, etc. as we are likely going to make more notable edits when we restructure our docs.
Get started with the ValidMind Library
Supported models
Run tests & test suites
Test descriptions
Test sandbox
Code samples
Code samples: QuickStart for Customer Churn Model Documentation — Full Suite
For some reason the old image links to JupyterHub & Colab don't actually work... you can't click on them, oops. I just changed them to our buttons to simplify the experience (and solve the links not working in one fell swoop).