Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Docs quick audit — ValidMind Library#593

Merged
validbeck merged 10 commits intomainvalidmind/documentation:mainfrom
beck/sc-6526/docs-audit-p3-developer-frameworkvalidmind/documentation:beck/sc-6526/docs-audit-p3-developer-frameworkCopy head branch name to clipboard
Dec 17, 2024
Merged

Docs quick audit — ValidMind Library#593
validbeck merged 10 commits intomainvalidmind/documentation:mainfrom
beck/sc-6526/docs-audit-p3-developer-frameworkvalidmind/documentation:beck/sc-6526/docs-audit-p3-developer-frameworkCopy head branch name to clipboard

Conversation

@validbeck
Copy link
Collaborator

@validbeck validbeck commented Dec 16, 2024

Internal Notes for Reviewers

sc-6526

Documentation drop-down icon

Realised I used the same icon for "Guides" and "About" when I fixed this, so:

Old New
Screenshot 2024-12-16 at 12 59 58 PM Screenshot 2024-12-16 at 1 11 26 PM

ValidMind Library portal

LIVE PREVIEW

Just some quick visual cleanup, made sure any images had alt-text & captions, etc. as we are likely going to make more notable edits when we restructure our docs.

Get started with the ValidMind Library

Old New
Screenshot 2024-12-16 at 12 58 49 PM Screenshot 2024-12-16 at 1 11 49 PM
Screenshot 2024-12-16 at 12 59 10 PM Screenshot 2024-12-16 at 1 12 00 PM

Supported models

Old New
Screenshot 2024-12-16 at 12 59 24 PM Screenshot 2024-12-16 at 1 12 51 PM
Screenshot 2024-12-16 at 12 59 39 PM Screenshot 2024-12-16 at 1 13 04 PM
Screenshot 2024-12-16 at 12 59 45 PM Screenshot 2024-12-16 at 1 13 11 PM

Run tests & test suites

Old New
Screenshot 2024-12-16 at 1 04 32 PM Screenshot 2024-12-16 at 1 13 58 PM

Test descriptions

Old New
Screenshot 2024-12-16 at 1 04 56 PM Screenshot 2024-12-16 at 1 14 06 PM

Test sandbox

Old New
Screenshot 2024-12-16 at 1 05 12 PM Screenshot 2024-12-16 at 1 14 13 PM

Code samples

Old New
Screenshot 2024-12-16 at 1 02 19 PM Screenshot 2024-12-16 at 1 15 30 PM
Code samples: QuickStart for Customer Churn Model Documentation — Full Suite

For some reason the old image links to JupyterHub & Colab don't actually work... you can't click on them, oops. I just changed them to our buttons to simplify the experience (and solve the links not working in one fell swoop).

@validbeck validbeck added the internal Not to be externalized in the release notes label Dec 16, 2024
@validbeck validbeck self-assigned this Dec 16, 2024
@validbeck validbeck requested a review from nrichers December 16, 2024 21:16
@github-actions
Copy link
Contributor

PR Summary

This pull request introduces several enhancements to the ValidMind documentation and user interface. Key changes include:

  1. Navigation and UI Updates:

    • Updated the icon for the "Guides" section in the navigation menu from a circle-info icon to a book icon for better representation.
    • Adjusted the layout and presentation of buttons and links across various documentation pages to improve user experience, including the addition of green button styling for better visibility.
  2. Content and Structural Improvements:

    • Revised the text and structure in multiple documentation files to enhance clarity and readability. This includes changes to the description of the ValidMind components and the supported models and libraries.
    • Added new content sections and reorganized existing ones to provide a more logical flow of information, particularly in the "Supported Models" and "Get Started" sections.
    • Introduced a new listing section in the "Supported Models" documentation to highlight the extensibility of the ValidMind developer tool for future model types.
  3. Code Samples and Interactive Elements:

    • Enhanced the presentation of code samples and interactive elements, such as Jupyter Notebooks, by updating links and button styles to encourage user engagement.
    • Improved the callout sections to better guide users through the documentation and testing processes.
  4. Miscellaneous:

    • Minor text edits and formatting changes to ensure consistency across the documentation.
    • Commented out unused sections to clean up the documentation files.

These changes aim to improve the overall user experience and accessibility of the ValidMind documentation, making it easier for developers to navigate and utilize the resources provided.

Test Suggestions

  • Verify that all updated icons and buttons render correctly across different browsers and devices.
  • Check that all links in the documentation, especially those in the new sections, direct to the correct pages.
  • Test the interactive elements, such as Jupyter Notebooks, to ensure they function as expected when accessed via the provided links.
  • Review the documentation for any broken links or missing images after the restructuring.
  • Ensure that the new content and structural changes do not introduce any inconsistencies or errors in the documentation.

Copy link
Collaborator

@nrichers nrichers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This generally looks fine and very reasonable but there are two changes that I am not sure add value and would omit:

  1. The two-column layout for supported models looks messier than the original, what with misaligned lines, and the layout generally makes it harder to read the content, IMHO.

    I'm pretty sure I tried a similar layout before and decided it just wasn't worth it. You'd have to go to a more rectilinear .feature layout similar to what we did for the LLM docs for this to work, I think, or revert to the original layout.

    image

  2. We can improve this page but adding buttons on the right that simply repeat what's already on the left seems quite superfluous?

    I could see the left sidebar matching the headings of these sections better — e.g. "Run tests & test suites" → "Learn how to run tests" — and skip the buttons.

image

Note that our own style guidelines recommend only linking to specific items, not to use them as a substitute for navigation:

Sometimes, it’s helpful to highlight a call to action with a button that takes you to a topic or to a notebook on JupyterHub.

@validbeck
Copy link
Collaborator Author

validbeck commented Dec 17, 2024

You'd have to go to a more rectilinear .feature layout

Would you believe that that was my first version of this and I reverted it because I thought "Nik will make me remove it"? 🫠 Can you explain why the two-column layouts seem OK to you in other places (that you implemented originally) like in our key concepts or even the supported modeling libraries and not here? To me, the two-column means less white-space on the right which looks a lot more uniform.

EDIT: Changing it from the definition headers to a bigger header is a bit clearer to me, does this adjustment work for you?

Screenshot 2024-12-17 at 9 15 13 AM

I could see the left sidebar matching the headings of these sections better — e.g. "Run tests & test suites" → "Learn how to run tests" — and skip the buttons.

These replaced the tiny "Learn more" links that got lost — I didn't ADD these links, I just changed them into more visible buttons. e.g.:

Screenshot 2024-12-17 at 9 06 16 AM

I also didn't rename these headers, they are the old ones so I am not sure what changes you want based on the arrows you have; can you make them in a commit so I can understand better?

EDIT: Also a reminder that this page is going to get entirely revamped in our upcoming reshuffle — so can we just deal with it then instead of quibbling about the minor details now?

@github-actions
Copy link
Contributor

A PR preview is available: Preview URL

Copy link
Collaborator

@nrichers nrichers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

EDIT: Also a reminder that this page is going to get entirely revamped in our upcoming reshuffle — so can we just deal with it then instead of quibbling about the minor details now?

The latest preview looks clean enough, LGTM. :shipit:

EDIT: As in, let's defer the other discussions until later, e.g. around renaming sidebar text to match section headings.

Would you believe that that was my first version of this and I reverted it because I thought "Nik will make me remove it"? 🫠

I actually like the benefits of .feature but I would simplify it it a bit in the future, similar to how we ended up using a simplified layout for the support ticket options. 😬

@validbeck validbeck merged commit a16b9c6 into main Dec 17, 2024
@validbeck validbeck deleted the beck/sc-6526/docs-audit-p3-developer-framework branch December 19, 2024 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal Not to be externalized in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.