Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Fix link to SR 11-7#588

Merged
nrichers merged 1 commit intomainvalidmind/documentation:mainfrom
nrichers-patch-1validmind/documentation:nrichers-patch-1Copy head branch name to clipboard
Dec 12, 2024
Merged

Fix link to SR 11-7#588
nrichers merged 1 commit intomainvalidmind/documentation:mainfrom
nrichers-patch-1validmind/documentation:nrichers-patch-1Copy head branch name to clipboard

Conversation

@nrichers
Copy link
Collaborator

@nrichers nrichers commented Dec 12, 2024

Internal Notes for Reviewers

Kevin pointed out this link to SR 11-7 in our glossary is broken, now fixed.

EDIT: Did a quick search through the repo and this looks to be the only occurrence of this particular malformed link.

External Release Notes

@nrichers nrichers added bug Something isn't working internal Not to be externalized in the release notes labels Dec 12, 2024
@nrichers nrichers requested a review from validbeck December 12, 2024 18:39
@github-actions
Copy link
Contributor

PR Summary

This pull request addresses a broken hyperlink in the glossary section of the site. Specifically, it corrects the URL in the definition of 'model' under the 'Models' section. The link previously pointed to an incorrect URL (sr1107.html) and has been updated to the correct URL (sr1107.htm). This change ensures that users can access the referenced document on Model Risk Management guidance without encountering a 404 error.

Test Suggestions

  • Verify that the updated link in the glossary section correctly navigates to the intended document on Model Risk Management.
  • Check for any other instances of broken links within the glossary or related sections.
  • Ensure that the glossary page renders correctly after the link update.

@github-actions
Copy link
Contributor

A PR preview is available: Preview URL

Copy link
Collaborator

@validbeck validbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weird! 🚀

@nrichers nrichers merged commit 5d4256b into main Dec 12, 2024
@nrichers nrichers deleted the nrichers-patch-1 branch December 12, 2024 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working internal Not to be externalized in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.