Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Workflow Python version fix#586

Merged
validbeck merged 9 commits intomainvalidmind/documentation:mainfrom
beck/python-version-fixvalidmind/documentation:beck/python-version-fixCopy head branch name to clipboard
Dec 12, 2024
Merged

Workflow Python version fix#586
validbeck merged 9 commits intomainvalidmind/documentation:mainfrom
beck/python-version-fixvalidmind/documentation:beck/python-version-fixCopy head branch name to clipboard

Conversation

@validbeck
Copy link
Collaborator

@validbeck validbeck commented Dec 11, 2024

Internal Notes for Reviewers

Since our last push to prod the workflow installing ValidMind so we can execute the demo notebook is failing: https://github.com/validmind/documentation/actions/runs/12266810562/job/34226405418?pr=580

Opening up a separate branch/PR to test.

Edits

  • Removed dependency check from composite actions
  • Set up Python 3.11 in the workflows so it's available for the rest of the steps

@validbeck validbeck added the internal Not to be externalized in the release notes label Dec 11, 2024
@validbeck validbeck self-assigned this Dec 11, 2024
@github-actions
Copy link
Contributor

A PR preview is available: Preview URL

@validbeck validbeck force-pushed the beck/python-version-fix branch from d8aa83f to 210f80b Compare December 12, 2024 02:16
@github-actions
Copy link
Contributor

A PR preview is available: Preview URL

Copy link
Contributor

@johnwalz97 johnwalz97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

guess I have to approve since you opened the PR :)

@github-actions
Copy link
Contributor

A PR preview is available: Preview URL

@validbeck validbeck merged commit 85562e0 into main Dec 12, 2024
@validbeck validbeck deleted the beck/python-version-fix branch December 12, 2024 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal Not to be externalized in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.