Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Execution workflows are driving Beck insane#569

Merged
validbeck merged 2 commits intomainvalidmind/documentation:mainfrom
beck/execution-workflows-2validmind/documentation:beck/execution-workflows-2Copy head branch name to clipboard
Dec 4, 2024
Merged

Execution workflows are driving Beck insane#569
validbeck merged 2 commits intomainvalidmind/documentation:mainfrom
beck/execution-workflows-2validmind/documentation:beck/execution-workflows-2Copy head branch name to clipboard

Conversation

@validbeck
Copy link
Collaborator

@validbeck validbeck commented Dec 4, 2024

Internal Notes for Reviewers

ohmygawddd i hate that you can't just test a workflow locally firstttt

Turns out it hates the ~1. The weird thing is, the FIRST execution of the staging filter found changed files, without extra parameters, but I DON'T UNDERSTAND WHY IT WORKED. 💀 Especially since I just inspected that workflow and it's checking the files against main. ????

I just noticed this in the docs though, which is slightly different than what I tried before (previously I tried ${{ github.head_ref }}):

Screenshot 2024-12-04 at 1 14 19 PM

@validbeck validbeck added the internal Not to be externalized in the release notes label Dec 4, 2024
@validbeck validbeck self-assigned this Dec 4, 2024
@validbeck validbeck requested a review from nrichers December 4, 2024 21:20
@github-actions
Copy link
Contributor

github-actions bot commented Dec 4, 2024

PR Summary

This pull request updates the GitHub Actions workflows for deploying documentation to both production and staging environments. The change involves modifying the base parameter in the dorny/paths-filter action from a hardcoded previous commit reference (prod~1 and staging~1) to dynamically use the current branch reference (${{ github.ref }}). This enhancement ensures that the paths filter operates based on the current branch, improving the accuracy and relevance of the deployment process.

Test Suggestions

  • Verify that the GitHub Actions workflows trigger correctly on both production and staging branches.
  • Check that the paths filter correctly identifies changes in the 'notebooks' directory when a new commit is pushed.
  • Ensure that the deployment process completes successfully without errors in both environments.
  • Test the workflow with a branch that has no changes in the 'notebooks' directory to confirm it does not trigger unnecessary deployments.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 4, 2024

A PR preview is available: Preview URL

nrichers
nrichers approved these changes Dec 4, 2024
View reviewed changes
Copy link
Collaborator

@nrichers nrichers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


@github-actions
Copy link
Contributor

github-actions bot commented Dec 4, 2024

A PR preview is available: Preview URL

@validbeck validbeck merged commit f5a538e into main Dec 4, 2024
@validbeck validbeck deleted the beck/execution-workflows-2 branch December 4, 2024 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nrichers nrichers nrichers approved these changes

Assignees

@validbeck validbeck

Labels

internal Not to be externalized in the release notes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@validbeck @nrichers
Morty Proxy This is a proxified and sanitized view of the page, visit original site.