Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Making changes for Mehdi :)#538

Merged
validbeck merged 3 commits intomainvalidmind/documentation:mainfrom
beck/pr#537-suggestionsvalidmind/documentation:beck/pr#537-suggestionsCopy head branch name to clipboard
Nov 26, 2024
Merged

Making changes for Mehdi :)#538
validbeck merged 3 commits intomainvalidmind/documentation:mainfrom
beck/pr#537-suggestionsvalidmind/documentation:beck/pr#537-suggestionsCopy head branch name to clipboard

Conversation

@validbeck
Copy link
Collaborator

@validbeck validbeck commented Nov 21, 2024

Internal Notes for Reviewers

Riffing on #537!

LIVE PREVIEW

Admin callout at the top of the page

This was already on the article, it links to our permissions guide:

Screenshot 2024-11-21 at 9 56 34 AM

Archive models

Updated the verbiage here to call out that you can reactivate, footnote just links to the subsequent section:

Screenshot 2024-11-21 at 9 56 51 AM

Delete models

Updated the footnotes here as they were shifted to accommodate for the additional one added in the above section:

Screenshot 2024-11-21 at 9 57 15 AM

mehdi0501 and others added 2 commits November 21, 2024 12:06
adding a note that only admin users can see archived models
@validbeck validbeck added the internal Not to be externalized in the release notes label Nov 21, 2024
@validbeck validbeck self-assigned this Nov 21, 2024
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ validbeck
❌ mehdi0501
You have signed the CLA already but the status is still pending? Let us recheck it.

1 similar comment
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ validbeck
❌ mehdi0501
You have signed the CLA already but the status is still pending? Let us recheck it.

@github-actions
Copy link
Contributor

A PR preview is available: Preview URL

@github-actions
Copy link
Contributor

PR Summary

This pull request enhances the model inventory guide by introducing the ability to reactivate archived models, making them available for use again. The documentation now clearly outlines the steps to archive, delete, and reactivate models within the inventory. Additionally, the PR updates references and footnotes to improve navigation and clarity within the guide.

Test Suggestions

  • Verify that the documentation correctly describes the process of archiving, deleting, and reactivating models.
  • Check that all footnote references are correctly linked and lead to the appropriate sections.
  • Ensure that the new reactivation feature is accurately reflected in the guide and matches the actual functionality of the software.

@validbeck validbeck merged commit 74222b4 into main Nov 26, 2024
@validbeck validbeck deleted the beck/pr#537-suggestions branch November 26, 2024 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal Not to be externalized in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.