Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Rework training section & update validator training#488

Merged
nrichers merged 35 commits intomainvalidmind/documentation:mainfrom
nrichers/sc-6622/update-validator-training-with-tracking-issuesvalidmind/documentation:nrichers/sc-6622/update-validator-training-with-tracking-issuesCopy head branch name to clipboard
Oct 28, 2024
Merged

Rework training section & update validator training#488
nrichers merged 35 commits intomainvalidmind/documentation:mainfrom
nrichers/sc-6622/update-validator-training-with-tracking-issuesvalidmind/documentation:nrichers/sc-6622/update-validator-training-with-tracking-issuesCopy head branch name to clipboard

Conversation

@nrichers
Copy link
Collaborator

@nrichers nrichers commented Oct 23, 2024

Internal Notes for Reviewers

They say you should leave the place better than you found it. I was in the process of updating our validator training but I decided that the structure of our training pages really needed some help. In this PR, I have:

  • Reworked the top-level training page to be less about the details of the training environment and more about available courses. Use fewer words and put the important stuff first.
  • Introduced course pages with registration links. Registration is a bit makeshift for now but single-sourced between the courses.
  • Renamed the training modules to explain that they cover the fundamentals, in preparation for future courses that will provide intermediate and advanced modules. That terminology seems easier to understand over courses that have "101" in the title which requires an understanding of academic course numbering schemes.
  • Added a template for course pages to make future course additions simpler.

These reworked training pages should move the needle for our nascent training program.

New top-level training page

LIVE PREVIEW

Before After
Capto_Capture 2024-10-24_06-12-18_PM Capto_Capture 2024-10-24_05-32-09_PM

New course pages

Administrator Fundamentals Developer Fundamentals Validator Fundamentals
image image image

New section for validator training

I also addressed the story for expanding our validator training with issue tracking & resolution:

  • Added a new "Track issue resolution" section in the validator training with new slides, one with the steps and the other for trying it out: Direct link
  • Single-sourced the new steps for tracking open issue resolution with our user guide:
  • Simplified some language & other minor tweaks. Examples:
    • Simplified "Select a model by clicking on it" > "Select a model" (redundant verbiage)
    • Moved "(Scroll down for the full instructions.)" directive into the column where the directive applies

New "Track issue resolution" section

Section Steps
image image
Try it out live User guide
image image

External Release Notes

We introduced a new training home page that makes it easier to find and register for our courses and expanded our validator training and user guide with more guidance for tracking and resolving the issues identified in model findings. Training{.button}

@nrichers nrichers marked this pull request as draft October 23, 2024 02:41
@nrichers nrichers changed the title Rework training section & update validator training Rework training section & update validator training — DRAFT, DO NOT REVIEW Oct 23, 2024
@github-actions
Copy link
Contributor

A PR preview is available: Preview URL

@nrichers nrichers changed the title Rework training section & update validator training — DRAFT, DO NOT REVIEW Rework training section & update validator training Oct 23, 2024
@nrichers nrichers marked this pull request as ready for review October 25, 2024 00:35
@github-actions
Copy link
Contributor

A PR preview is available: Preview URL

@nrichers nrichers added the documentation Improvements or additions to documentation label Oct 25, 2024
@nrichers nrichers requested a review from validbeck October 25, 2024 01:18
@github-actions
Copy link
Contributor

PR Summary

This pull request introduces several enhancements and bug fixes to the ValidMind documentation and training templates. Key changes include:

  1. New Course Templates: Added new course templates for Administrator Fundamentals, Developer Fundamentals, and Validator Fundamentals. These templates provide structured learning paths for different roles within the ValidMind platform.

    • Each course template includes sections for learning objectives, course content, and registration details.
    • The templates also include support and feedback mechanisms via Slack and email.
  2. Documentation Updates: Updated various documentation files to improve clarity and consistency.

    • Replaced instances of "Select a model by clicking on it" with "Select a model or find your model by applying a filter or searching for it" for better user guidance.
    • Updated navigation links and file paths to reflect the new course structures.
  3. Navigation and UI Enhancements: Modified the site navigation to include new training paths and updated links to reflect the new course structures.

    • Updated _quarto.yml to reflect changes in the training section.
    • Adjusted iframe links in index.qmd to point to the new course pages.
  4. Issue Tracking for Validation: Added a new section for tracking issue resolution in the validation process.

    • This includes guidance on assessing open issues and determining the severity of findings.

These changes aim to enhance the user experience by providing clearer guidance and structured learning paths for different user roles.

Test Suggestions

  • Verify that all new course templates render correctly and include all necessary sections.
  • Test the registration and support links in the new course templates to ensure they direct users to the correct resources.
  • Check that the updated navigation links in _quarto.yml reflect the new course structures and are functional.
  • Ensure that the updated phrasing in documentation files improves clarity and does not introduce any navigation issues.
  • Test the issue tracking section in the validation process to ensure it provides accurate guidance on assessing and resolving findings.

@github-actions
Copy link
Contributor

A PR preview is available: Preview URL

@github-actions
Copy link
Contributor

A PR preview is available: Preview URL

@github-actions
Copy link
Contributor

A PR preview is available: Preview URL

@nrichers
Copy link
Collaborator Author

  • I don't like that all of the images are the same. I think this doesn't add anything.

Let's chat at our community standup. I agree that having the same images be the same is also not great but it feels like a lesser evil. I did actually look into whether the tiles for listing pages could embed live content, but I'm not sure it's easy. Maybe there is some middle ground — e.g. I could even just use screenshots of the training title pages.

  • I also don't like that we use the .html links in the iframes for the previews... again, complex code for no reason.

Related to the complexity introduced by the HTML code, agreed. I ran out of time on making improvements, but let me spend a bit of time this afternoon to create a new class for this.

@nrichers
Copy link
Collaborator Author

nrichers commented Oct 26, 2024

  • I also don't like that we use the .html links in the iframes for the previews... again, complex code for no reason.

Related to the complexity introduced by the HTML code, agreed. I ran out of time on making improvements, but let me spend a bit of time this afternoon to create a new class for this.

I solved this issue. We now have a new extension via da2ed0e that allows you to use course-preview with .qmd files, e.g.

::: {.course-preview src="validator-fundamentals.qmd"}
:::

Style guide info coming shortly ...

EDIT: This renders as follows, which actually works better than the iframe HTML we had before because I was able to omit the pink band at the bottom.

image

@github-actions
Copy link
Contributor

A PR preview is available: Preview URL

@github-actions
Copy link
Contributor

A PR preview is available: Preview URL

@github-actions
Copy link
Contributor

A PR preview is available: Preview URL

@github-actions
Copy link
Contributor

A PR preview is available: Preview URL

@github-actions
Copy link
Contributor

A PR preview is available: Preview URL

@nrichers
Copy link
Collaborator Author

I strongly prefer if we revert to the original graphics or the preview for the courses and will push a commit to that effect.

  • I don't like that all of the images are the same. I think this doesn't add anything.

If my extension for course previews was decidedly more clever, my solution for this issue is rather low tech: For now, I have added images of the title page for each course.

image

There's very likely a better way to handle this but I'm out of time on this PR. In the future, we might look into a more bespoke listing tile we can create that also shows the live preview or automatically generate images from an URL.

@github-actions
Copy link
Contributor

A PR preview is available: Preview URL

@nrichers
Copy link
Collaborator Author

nrichers commented Oct 28, 2024

If my extension for course previews were a bit more clever ...

I spent some time over the weekend thinking about this. I think the future of this extension lies in creating a more flexible version of the listing page tiles we've been using, which have some quirks we've been working around. I envision updating this extension to:

  • Preview any relevant page based on context, such as our upcoming interactive tech demo on the front page
  • Preview specific sections from a page or render code cells in real time, surfacing parts of an interactive notebook
  • Integrate the chatbot MVP cleanly on the front page or any other page without resorting to low-level page modifications
  • Use one page as a teaser (e.g., a training module) but link to another (e.g., the registration page)

This morning, I’ll spend an hour reworking the extension to make it a bit more generic in name (page-preview preview comes to mind) and will document the rest for the future in a story. For now, this extension shows that we can extend Quarto quickly and effectively.

@github-actions
Copy link
Contributor

A PR preview is available: Preview URL

1 similar comment
@github-actions
Copy link
Contributor

A PR preview is available: Preview URL

@github-actions
Copy link
Contributor

A PR preview is available: Preview URL

@github-actions
Copy link
Contributor

A PR preview is available: Preview URL

@nrichers nrichers merged commit e0c9960 into main Oct 28, 2024
@nrichers nrichers deleted the nrichers/sc-6622/update-validator-training-with-tracking-issues branch October 28, 2024 19:02
@validbeck
Copy link
Collaborator

validbeck commented Oct 28, 2024

Nice!!

The only thing is, why is Administrator Fundamentals in two rows? Strange...

EDIT: Oh I see, for some reason the file itself has a <br> in the title... 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.