Nrichers/sc 6760/store python docs as zip file and extract#461
Merged
nrichers merged 7 commits intomainvalidmind/documentation:mainfrom Oct 10, 2024
nrichers/sc-6760/store-python-docs-as-zip-file-and-extractvalidmind/documentation:nrichers/sc-6760/store-python-docs-as-zip-file-and-extractCopy head branch name to clipboard
Merged
Nrichers/sc 6760/store python docs as zip file and extract#461nrichers merged 7 commits intomainvalidmind/documentation:mainfrom nrichers/sc-6760/store-python-docs-as-zip-file-and-extractvalidmind/documentation:nrichers/sc-6760/store-python-docs-as-zip-file-and-extractCopy head branch name to clipboard
nrichers merged 7 commits intomainvalidmind/documentation:mainfrom
nrichers/sc-6760/store-python-docs-as-zip-file-and-extractvalidmind/documentation:nrichers/sc-6760/store-python-docs-as-zip-file-and-extractCopy head branch name to clipboard
Conversation
Contributor
|
A PR preview is available: Preview URL |
1 similar comment
Contributor
|
A PR preview is available: Preview URL |
validbeck
approved these changes
Oct 9, 2024
Collaborator
validbeck
left a comment
There was a problem hiding this comment.
Sorry I lost this in my inbox for a while! It looks good, thank you for setting it up!
sc-6760/store-python-docs-as-zip-file-and-extract
Contributor
|
A PR preview is available: Preview URL |
Contributor
|
A PR preview is available: Preview URL |
Collaborator
Author
|
There was an issue with the paths inside the .zip file which is why the preview didn't work. Fixed in 90a5b0d — now the preview works as expected and the Python docs also work locally. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Internal Notes for Reviewers
This PR modifies the
make python-docsaction to replace our folder of HMTL Python docs with a single .zip file that gets unzipped on the fly. This change should stopgit statusfrom cluttering your view if you runquarto preview.Easiest way to test, requires that you ran
make get-sourceat some point:site/python-docs.zipand thesite/_site/validmind/folder.quarto renderand check that thepython-docs.zipfile reappears in the site output folder and that the ValidMind Developer Framework reference still works when you open the docs site locally.External Release Notes