Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Add link to GitHub for code samples#460

Merged
nrichers merged 3 commits intomainvalidmind/documentation:mainfrom
nrichers/sc-6637/add-github-repo-option-to-code-samples-pagevalidmind/documentation:nrichers/sc-6637/add-github-repo-option-to-code-samples-pageCopy head branch name to clipboard
Oct 4, 2024
Merged

Add link to GitHub for code samples#460
nrichers merged 3 commits intomainvalidmind/documentation:mainfrom
nrichers/sc-6637/add-github-repo-option-to-code-samples-pagevalidmind/documentation:nrichers/sc-6637/add-github-repo-option-to-code-samples-pageCopy head branch name to clipboard

Conversation

@nrichers
Copy link
Collaborator

@nrichers nrichers commented Oct 2, 2024 •
edited
Loading

Internal Notes for Reviewers

This PR adds a link to our open-source repo on GitHub:

image

LIVE PREVIEW

External Release Notes

We added a link to our open-source software on GitHub to the code samples page. Try it on GitHub

@nrichers nrichers added the documentation Improvements or additions to documentation label Oct 2, 2024
@nrichers nrichers requested a review from validbeck October 2, 2024 02:02
@github-actions
Copy link
Contributor

github-actions bot commented Oct 2, 2024

PR Summary

This pull request enhances the Jupyter Notebooks sample page by adding a new button that directs users to the GitHub repository for the developer framework. The changes include:

  • Adding a new button labeled 'Try it on GitHub' that links to the GitHub repository https://github.com/validmind/developer-framework.
  • Adjusting the layout by adding a spacer and modifying the width of existing elements to accommodate the new button.

These changes aim to provide users with an additional option to explore the developer framework directly on GitHub, thereby improving accessibility and user experience.

Test Suggestions

  • Verify that the new 'Try it on GitHub' button is displayed correctly on the Jupyter Notebooks sample page.
  • Ensure that the button links to the correct GitHub repository URL: https://github.com/validmind/developer-framework.
  • Check the layout of the page to ensure that the new button does not disrupt the existing elements and that the page is responsive across different screen sizes.
  • Test the functionality of the other buttons ('Try Notebooks on JupyterHub' and 'Download Notebooks & Datasets') to ensure they are not affected by the new changes.

validbeck
validbeck approved these changes Oct 4, 2024
View reviewed changes
Copy link
Collaborator

@validbeck validbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why the render & PR preview link failed, but it looks fine locally.

Just made some adjustments to the padding as it was wonky:

Screenshot 2024-10-04 at 1 04 02 PM

@github-actions
Copy link
Contributor

github-actions bot commented Oct 4, 2024

A PR preview is available: Preview URL

@nrichers nrichers merged commit cbbdbae into main Oct 4, 2024
@nrichers nrichers deleted the nrichers/sc-6637/add-github-repo-option-to-code-samples-page branch October 4, 2024 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@validbeck validbeck validbeck approved these changes

Assignees

No one assigned

Labels

documentation Improvements or additions to documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nrichers @validbeck
Morty Proxy This is a proxified and sanitized view of the page, visit original site.