Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Deployment architecture docs#459

Merged
nrichers merged 20 commits intomainvalidmind/documentation:mainfrom
nrichers/sc-6306/document-deployment-options-for-validmindvalidmind/documentation:nrichers/sc-6306/document-deployment-options-for-validmindCopy head branch name to clipboard
Oct 16, 2024
Merged

Deployment architecture docs#459
nrichers merged 20 commits intomainvalidmind/documentation:mainfrom
nrichers/sc-6306/document-deployment-options-for-validmindvalidmind/documentation:nrichers/sc-6306/document-deployment-options-for-validmindCopy head branch name to clipboard

Conversation

@nrichers
Copy link
Collaborator

@nrichers nrichers commented Oct 1, 2024

Internal Notes for Reviewers

This PR adds a new section for deployment options, a new topic for configuring Azure Private Link, and makes some minor terminology changes to remove trigger words.

LIVE PREVIEW:

  • Untested, need Cullen to review with me.

External Release Notes

We expanded our documentation on available deployment options for ValidMind, providing more information for both multi-tentant cloud and single-tentant options. Learn more ...

@nrichers nrichers added the internal Not to be externalized in the release notes label Oct 1, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Oct 1, 2024

A PR preview is available: Preview URL

@github-actions
Copy link
Contributor

github-actions bot commented Oct 2, 2024

A PR preview is available: Preview URL

@nrichers nrichers added documentation Improvements or additions to documentation and removed internal Not to be externalized in the release notes labels Oct 2, 2024
@nrichers nrichers requested review from cachafla and eggshell October 2, 2024 01:37
@github-actions
Copy link
Contributor

github-actions bot commented Oct 2, 2024

PR Summary

This pull request introduces several significant enhancements to the documentation of the ValidMind platform. The key changes include:

  1. New Deployment Options Section: A new section has been added to the documentation to describe the different deployment options available for ValidMind. This includes detailed descriptions of the multi-tenant cloud and Virtual Private ValidMind (VPV) deployment models.

    • Multi-tenant Cloud: Allows multiple customers to share the same infrastructure while ensuring strict data isolation.
    • Virtual Private ValidMind (VPV): A single-tenant architecture providing greater control, customization, and enhanced security.
  2. Azure Private Link Configuration: A new guide has been added to help users configure Azure Private Link for secure and private communication between Azure Virtual Network (VNet) resources and ValidMind.

  3. Updates to Existing Documentation: Minor updates have been made to existing documentation to align with the new deployment options and to improve clarity. This includes changes to the data privacy policy and API integration descriptions.

  4. New Images and Diagrams: New images and diagrams have been added to visually represent the deployment options and the architecture of the ValidMind platform.

These changes aim to provide users with comprehensive information on deployment options and enhance the security and privacy of their network configurations.

Test Suggestions

  • Verify that the new deployment options section is correctly rendered and accessible in the documentation.
  • Check the links and references in the new deployment options section to ensure they point to the correct resources.
  • Test the Azure Private Link configuration guide by following the steps to set up a private endpoint and verify connectivity.
  • Ensure that the images and diagrams are correctly displayed and have appropriate alt text for accessibility.
  • Review the updated data privacy policy and API integration sections for accuracy and clarity.

@nrichers nrichers changed the title IN PROGRESS, DO NOT REVIEW Deployment architecture docs Oct 2, 2024
@nrichers
Copy link
Collaborator Author

nrichers commented Oct 2, 2024

@cachafla @validbeck my apologies, I had not changed the title of the PR before requesting review from you — this PR includes the docs for the deployment architecture info we had talked about.

@validbeck validbeck self-requested a review October 4, 2024 22:08
@github-actions
Copy link
Contributor

github-actions bot commented Oct 4, 2024

PR Summary

This pull request introduces several enhancements to the documentation of the ValidMind platform, focusing on deployment options and secure network configurations. The key changes include:

  1. Deployment Options Documentation: A new section titled "Deployment options" has been added, detailing the available deployment models for ValidMind:

    • Multi-tenant Cloud: This model allows multiple organizations to share infrastructure while maintaining data isolation. It offers cost-efficiency, scalability, and centralized updates.
    • Virtual Private ValidMind (VPV): A single-tenant architecture providing exclusive infrastructure access, ideal for high-compliance needs with enhanced security and control.
  2. Azure Private Link Configuration: A new guide has been added to configure Azure Private Link, enabling secure and private communication between Azure Virtual Network resources and ValidMind. This guide includes step-by-step instructions for setting up a private endpoint and ensuring secure access to ValidMind services.

  3. Security and Data Privacy Enhancements: The documentation now emphasizes data security measures, including data isolation, encryption, and role-based access controls. It also highlights compliance with SOC 2 standards and the absence of PII in API communications.

  4. Minor Textual Updates: Adjustments have been made to the language in various files to improve clarity and consistency, such as changing references from "SaaS API" to "API" and updating descriptions related to deployment and security features.

Test Suggestions

  • Verify that the new deployment options documentation is correctly rendered and accessible on the website.
  • Test the Azure Private Link configuration guide by following the steps to ensure they result in a successful private endpoint setup.
  • Check for broken links or missing images in the newly added documentation sections.
  • Ensure that the security and data privacy information is accurately reflected and consistent across all relevant documentation pages.

Copy link
Collaborator

@validbeck validbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ohh, so much good info!

Now down to the mean stuff:

  • Virtual Private ValidMind (VPV) — Maybe we want top add this to the variables?
  • I'm not a fan of the request a demo button. Maybe make that section into a callout instead?
Screenshot 2024-10-04 at 3 15 39 PM
  • The "What's next" in Managing your organization needs the new Azure page added to it (and the grid-columns adjusted to display 2 on each row)
Screenshot 2024-10-04 at 3 16 15 PM
  • For the Azure Steps 1c - e maybe we want some line breaks here?
Screenshot 2024-10-04 at 3 22 42 PM

site/guide/configuration/configure-azure-private-link.qmd Outdated Show resolved Hide resolved
@github-actions
Copy link
Contributor

github-actions bot commented Oct 4, 2024

A PR preview is available: Preview URL

@cachafla
Copy link
Contributor

cachafla commented Oct 4, 2024

@cachafla @validbeck my apologies, I had not changed the title of the PR before requesting review from you — this PR includes the docs for the deployment architecture info we had talked about.

Sorry for the delay, I'll start reviewing.

site/about/deployment/deployment-options.qmd Outdated Show resolved Hide resolved
site/about/deployment/deployment-options.qmd Outdated Show resolved Hide resolved
site/about/deployment/deployment-options.qmd Show resolved Hide resolved
@cachafla
Copy link
Contributor

cachafla commented Oct 8, 2024

In general I recommend using "private link connection" whenever we say "VPC connection". A VPC is just the "place" where a deployment. For example, we should say "private link" in this diagram:

image

…ind' of github.com:validmind/documentation into nrichers/sc-6306/document-deployment-options-for-validmind
@github-actions
Copy link
Contributor

A PR preview is available: Preview URL

1 similar comment
@github-actions
Copy link
Contributor

A PR preview is available: Preview URL

@github-actions
Copy link
Contributor

A PR preview is available: Preview URL

@nrichers
Copy link
Collaborator Author

@validbeck thank you for reviewing! I believe I have addressed your comments.

**Virtual Private ValidMind (VPV) — Maybe we want top add this to the variables?

Yup, done! I did not variablify "multi-tenant cloud", as it's not a proper name.

I'm not a fan of the request a demo button. Maybe make that section into a callout instead?**

Done in both places (you had done one already).

For the Azure Steps 1c - e maybe we want some line breaks here?

You'd added some it seems but the spacing is at odds with what's further down, see the "Before" screenshot. I tried spacing out all substeps but the topic just ends up a mess of whitespace. As a compromise, I put the different options you select on their own bullets and then removed some of the spacing again. This puts the topic more in line with the other private link content we have.

Before After
image image

@github-actions
Copy link
Contributor

A PR preview is available: Preview URL

@validbeck
Copy link
Collaborator

As a compromise, I put the different options you select on their own bullets and then removed some of the spacing again.

Nice, that was going to be my alternative suggestion!

@nrichers
Copy link
Collaborator Author

@cachafla I believe I have addressed your comments.

In general I recommend using "private link connection" whenever we say "VPC connection"

Thank you! Changed to "private link" or "private link connection in all the deployment content, for both text and graphics.

@github-actions
Copy link
Contributor

A PR preview is available: Preview URL

@github-actions
Copy link
Contributor

A PR preview is available: Preview URL

@validbeck
Copy link
Collaborator

The callout was still quite cosmetically inelegant... so...

Screenshot 2024-10-15 at 3 08 36 PM

…ind' of github.com:validmind/documentation into nrichers/sc-6306/document-deployment-options-for-validmind
@github-actions
Copy link
Contributor

A PR preview is available: Preview URL

@nrichers nrichers merged commit 94443be into main Oct 16, 2024
@nrichers nrichers deleted the nrichers/sc-6306/document-deployment-options-for-validmind branch October 16, 2024 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.