Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Updated Jupyter Notebooks to match prod branch#267

Merged
validbeck merged 1 commit intomainvalidmind/documentation:mainfrom
beck/notebook-updatesvalidmind/documentation:beck/notebook-updatesCopy head branch name to clipboard
Aug 9, 2024
Merged

Updated Jupyter Notebooks to match prod branch#267
validbeck merged 1 commit intomainvalidmind/documentation:mainfrom
beck/notebook-updatesvalidmind/documentation:beck/notebook-updatesCopy head branch name to clipboard

Conversation

@validbeck
Copy link
Collaborator

Internal Notes for Reviewers

Remember our very tired day where we kept needing to adjust the new names of notebooks?

We updated the notebooks for the prod branch (so the live site is fine) but our current main branch is now behind on the notebook renames so any local previews / renders won't show the corrected notebooks. I've fixed this by pulling in the latest notebooks from developer-framework.

@validbeck validbeck added the internal Not to be externalized in the release notes label Aug 8, 2024
@validbeck validbeck self-assigned this Aug 8, 2024
@validbeck validbeck requested review from noosheenv and nrichers August 8, 2024 21:40
Copy link
Collaborator

@nrichers nrichers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM — also checked that the path name for NLP and LLM notebooks in the main branch is correct (it is). 🚀

@validbeck validbeck merged commit f069c7a into main Aug 9, 2024
@validbeck validbeck deleted the beck/notebook-updates branch August 15, 2024 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal Not to be externalized in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.