Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Edits to Approval step on Set up workflows#264

Merged
validbeck merged 1 commit intomainvalidmind/documentation:mainfrom
beck/sc-5418/documentation-workflow-approval-step-shouldvalidmind/documentation:beck/sc-5418/documentation-workflow-approval-step-shouldCopy head branch name to clipboard
Aug 1, 2024
Merged

Edits to Approval step on Set up workflows#264
validbeck merged 1 commit intomainvalidmind/documentation:mainfrom
beck/sc-5418/documentation-workflow-approval-step-shouldvalidmind/documentation:beck/sc-5418/documentation-workflow-approval-step-shouldCopy head branch name to clipboard

Conversation

@validbeck
Copy link
Collaborator

Internal Notes for Reviewers

For sc-5418, I edited the "Approval" step details on set-up-model-workflows.qmd

Old New
Screenshot 2024-08-01 at 2 37 43 PM Screenshot 2024-08-01 at 2 37 14 PM

@validbeck validbeck added the internal Not to be externalized in the release notes label Aug 1, 2024
@validbeck validbeck self-assigned this Aug 1, 2024
@validbeck validbeck requested review from noosheenv and nrichers August 1, 2024 21:41
Copy link
Contributor

@noosheenv noosheenv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested the new steps and is accurate! Workflows are so thick dude props to you for making the guide

@validbeck validbeck merged commit ac5bcd0 into main Aug 1, 2024
@validbeck validbeck deleted the beck/sc-5418/documentation-workflow-approval-step-should branch August 1, 2024 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal Not to be externalized in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.