Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Documented new 2 step model registration#253

Merged
noosheenv merged 10 commits intomainvalidmind/documentation:mainfrom
beck/sc-5499/documentation-new-2-step-model-registrationvalidmind/documentation:beck/sc-5499/documentation-new-2-step-model-registrationCopy head branch name to clipboard
Jul 18, 2024
Merged

Documented new 2 step model registration#253
noosheenv merged 10 commits intomainvalidmind/documentation:mainfrom
beck/sc-5499/documentation-new-2-step-model-registrationvalidmind/documentation:beck/sc-5499/documentation-new-2-step-model-registrationCopy head branch name to clipboard

Conversation

@validbeck
Copy link
Collaborator

Internal Notes for Reviewers

For sc-5499.

Register models in the inventory

Updated this page to match the new two-panel layout if custom fields are configured on the organization:

Screenshot 2024-07-17 at 9 20 49 AM

Working with model workflows

  • Added a new smallcaps style to our stylesheet and updated the style guide
  • Applied it to our relevant "MODEL STATUS" UI text as that is how it appears in the UI
  • This is easily applied via the [model status]{.smallcaps} format
Example usage Style guide update
Screenshot 2024-07-17 at 9 07 52 AM Screenshot 2024-07-17 at 9 29 18 AM

I also preemptively updated some of the casing I made more unified in this PR over in frontend: https://github.com/validmind/frontend/pull/870

@validbeck validbeck added the internal Not to be externalized in the release notes label Jul 17, 2024
@validbeck validbeck requested review from noosheenv and nrichers July 17, 2024 16:34
@validbeck validbeck self-assigned this Jul 17, 2024
@validbeck validbeck requested review from noosheenv and nrichers and removed request for noosheenv and nrichers July 17, 2024 17:57
Copy link
Contributor

@noosheenv noosheenv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some stuff from the first pass-through of testing these docs. Plus, there is that owners bug in the frontend so it's kinda fun and quirky for now. Good stuff otherwise!

@validbeck
Copy link
Collaborator Author

validbeck commented Jul 17, 2024

New updates:

  • Split out the basic & additional panels into their own sections
  • Expanded on the required default fields, as well as the conditional fields

Screenshot 2024-07-17 at 3 41 31 PM

@validbeck validbeck requested a review from noosheenv July 17, 2024 22:12
Copy link
Contributor

@noosheenv noosheenv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@noosheenv noosheenv merged commit 2b97be5 into main Jul 18, 2024
@noosheenv noosheenv deleted the beck/sc-5499/documentation-new-2-step-model-registration branch July 18, 2024 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal Not to be externalized in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.