Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Reimplemented CSS grid with Tachyons Flexbox instead#252

Merged
validbeck merged 18 commits intomainvalidmind/documentation:mainfrom
beck/sc-5191/quarto-grid-is-not-responsivevalidmind/documentation:beck/sc-5191/quarto-grid-is-not-responsiveCopy head branch name to clipboard
Jul 17, 2024
Merged

Reimplemented CSS grid with Tachyons Flexbox instead#252
validbeck merged 18 commits intomainvalidmind/documentation:mainfrom
beck/sc-5191/quarto-grid-is-not-responsivevalidmind/documentation:beck/sc-5191/quarto-grid-is-not-responsiveCopy head branch name to clipboard

Conversation

@validbeck
Copy link
Collaborator

@validbeck validbeck commented Jul 16, 2024

Internal Notes for Reviewers

For sc-5191.

Improved mobile responsive Tachyons Flexbox replacing CSS grid

Old New
Video Video

Where possible, Tachyons Flexbox functionality now replaces the formerly not-mobile-responsive at all CSS grid. Changes on live on docs-demo. Above recorded on my Samsung Galaxy 23 Ultra (Android).

  • 2 exceptions in the styling of video widths, as Quarto's dimension option for videos isn't very effective and actually makes the situation worse on both mobile & desktop:
  1. developer/get-started-developer-framework.qmd
  2. get-started/developer/try-with-jupyterhub.qmd
Screenshot 2024-07-16 at 3 36 09 PM

fig-alt text additions & adjustments

@validbeck validbeck self-assigned this Jul 16, 2024
@validbeck validbeck added the internal Not to be externalized in the release notes label Jul 16, 2024
@validbeck validbeck requested review from noosheenv and nrichers July 16, 2024 23:04
Copy link
Collaborator

@nrichers nrichers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Demoed during Community catchup, looks great. 🚀

@validbeck validbeck merged commit 1f3d896 into main Jul 17, 2024
@validbeck validbeck deleted the beck/sc-5191/quarto-grid-is-not-responsive branch July 17, 2024 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal Not to be externalized in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.