Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Fixing Makefile to not change nlp_and_llm to NLP_and_LLM#243

Merged
noosheenv merged 1 commit intomainvalidmind/documentation:mainfrom
noosheenvazinkhoo/sc-5271/broken-links-in-notebooks-referring-to-nlpvalidmind/documentation:noosheenvazinkhoo/sc-5271/broken-links-in-notebooks-referring-to-nlpCopy head branch name to clipboard
Jul 9, 2024
Merged

Fixing Makefile to not change nlp_and_llm to NLP_and_LLM#243
noosheenv merged 1 commit intomainvalidmind/documentation:mainfrom
noosheenvazinkhoo/sc-5271/broken-links-in-notebooks-referring-to-nlpvalidmind/documentation:noosheenvazinkhoo/sc-5271/broken-links-in-notebooks-referring-to-nlpCopy head branch name to clipboard

Conversation

@noosheenv
Copy link
Contributor

@noosheenv noosheenv commented Jul 5, 2024

Internal Notes for Reviewers

Was trying to fix the folder name to nlp_and_llm and make it still display NLP and LLM but that was a sad sad rabbit hole. As per the recent comments on the associated story, I just fixed the file name by editing the Makefile.

The other files changed were just from running make notebooks for testing and from running quarto render as well.

External Release Notes

@noosheenv noosheenv added DO NOT MERGE PR is not ready to be merged internal Not to be externalized in the release notes labels Jul 5, 2024
@noosheenv noosheenv self-assigned this Jul 5, 2024
@noosheenv noosheenv requested review from nrichers and validbeck July 5, 2024 22:58
@noosheenv noosheenv force-pushed the noosheenvazinkhoo/sc-5271/broken-links-in-notebooks-referring-to-nlp branch from 9c68c0f to 19e5ad5 Compare July 5, 2024 23:44
@noosheenv noosheenv removed the DO NOT MERGE PR is not ready to be merged label Jul 5, 2024
@noosheenv noosheenv changed the title Renaming folder and creating workaround for NLP and LLM Fixing Makefile to not change nlp_and_llm to NLP_and_LLM Jul 5, 2024
Copy link
Collaborator

@nrichers nrichers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🐰 🕳️

@noosheenv noosheenv merged commit 2e7ad9f into main Jul 9, 2024
@noosheenv noosheenv deleted the noosheenvazinkhoo/sc-5271/broken-links-in-notebooks-referring-to-nlp branch July 9, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal Not to be externalized in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.