Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Documentation for inserting math formulas#204

Merged
noosheenv merged 8 commits intomainvalidmind/documentation:mainfrom
noosheenvazinkhoo/sc-4422/documentation-support-for-latex-formulasvalidmind/documentation:noosheenvazinkhoo/sc-4422/documentation-support-for-latex-formulasCopy head branch name to clipboard
May 27, 2024
Merged

Documentation for inserting math formulas#204
noosheenv merged 8 commits intomainvalidmind/documentation:mainfrom
noosheenvazinkhoo/sc-4422/documentation-support-for-latex-formulasvalidmind/documentation:noosheenvazinkhoo/sc-4422/documentation-support-for-latex-formulasCopy head branch name to clipboard

Conversation

@noosheenv
Copy link
Contributor

Internal Notes for Reviewers

I added a section to "Work with content blocks" under "Add content blocks" called "Add mathematical formulas". Feedback on the wording and level of detail is appreciated! Should I go more step-by-step, or is it best to just have that link to CK Editor's docs?
image

External Release Notes

@noosheenv noosheenv added the internal Not to be externalized in the release notes label May 27, 2024
@noosheenv noosheenv requested review from nrichers and validbeck May 27, 2024 17:20
@noosheenv noosheenv self-assigned this May 27, 2024
@CLAassistant
Copy link

CLAassistant commented May 27, 2024

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Collaborator

@nrichers nrichers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great start for these docs! My main comment would be that this is a task which should be procedural, i.e. it should have numbered steps.

site/guide/work-with-content-blocks.qmd Outdated Show resolved Hide resolved
site/guide/work-with-content-blocks.qmd Outdated Show resolved Hide resolved
site/guide/work-with-content-blocks.qmd Show resolved Hide resolved
@validbeck
Copy link
Collaborator

@noosheenv Nik has a good point that we don't expose that we use CK Editor, so I'd make a slight adjustment to the section with a gif instead of the link out to the docs. I've just sent a quick commit up to accommodate for the gif, so pull it down and see if you can complete the suggested changes. :)

Copy link
Collaborator

@nrichers nrichers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of small additional comments on the new content but LGTM otherwise (looks GREAT to me). 🚀🚀🚀

site/guide/work-with-content-blocks.qmd Outdated Show resolved Hide resolved
site/guide/work-with-content-blocks.qmd Outdated Show resolved Hide resolved
Copy link
Collaborator

@validbeck validbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, looks good to me as well. :)

…o noosheenvazinkhoo/sc-4422/documentation-support-for-latex-formulas
@noosheenv noosheenv merged commit f05a34a into main May 27, 2024
@noosheenv noosheenv deleted the noosheenvazinkhoo/sc-4422/documentation-support-for-latex-formulas branch May 27, 2024 21:14
validbeck added a commit that referenced this pull request Oct 8, 2024
validbeck added a commit that referenced this pull request Oct 9, 2024
* Added screenshot class to Sept 25 2024 release notes

* Removed references to projects in core docs 1st pass

* Removed references to projects in core docs 2nd pass

* Removed references to projects in core docs final-ish pass

* Updated model activity info

* Final tweaks

* Pulled in latest notebook edits from developer-framework PR#203

* Removing empty cell from intro_for_model_developers.ipynb

* Pulled in latest from developer-framework #204
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal Not to be externalized in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.