Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Move .env and .env.example into root of repo#189

Merged
nrichers merged 3 commits intomainvalidmind/documentation:mainfrom
lets-try-this-againvalidmind/documentation:lets-try-this-againCopy head branch name to clipboard
May 9, 2024
Merged

Move .env and .env.example into root of repo#189
nrichers merged 3 commits intomainvalidmind/documentation:mainfrom
lets-try-this-againvalidmind/documentation:lets-try-this-againCopy head branch name to clipboard

Conversation

@nrichers
Copy link
Collaborator

@nrichers nrichers commented May 9, 2024

Internal Notes for Reviewers

Next try! This PR:

  • Moves the .env.example file up a level into the root of the repo so it's not in Quarto's way
  • Modifies the release notes script to look for a .env file in the root of the repo
  • Updates .gitignore to fix the path for the .quarto folder (which does need to be inside of site/)

Tested the release notes script after the update to make sure everything works:

❯ make release-notes
Enter a full GitHub release URL (leave empty to finish): https://github.com/validmind/documentation/releases/tag/v2.0.7
Enter a full GitHub release URL (leave empty to finish): 
Enter the release date (Month Day, Year) [May 14, 2024]: 
Generating & editing release notes ...
  Processing validmind/documentation/#166 ...
  Processing validmind/documentation/#165 ...
  Processing validmind/documentation/#172 ...
  Processing validmind/documentation/#169 ...
  Processing validmind/documentation/#171 ...
  Processing validmind/documentation/#170 ...
Added release notes to _quarto.yml, line 96
Files to commit:
 M _quarto.yml
?? releases/2024-may-14/

External Release Notes

@nrichers nrichers added infrastructure Docs infra changes internal Not to be externalized in the release notes labels May 9, 2024
@nrichers nrichers requested review from noosheenv and validbeck May 9, 2024 21:58
@nrichers nrichers changed the title Lets try this again Move .env and .env.example into root of repo May 9, 2024
Copy link
Collaborator

@validbeck validbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moves the .env.example file up a level into the root of the repo so it's not in Quarto's way

success!

Modifies the release notes script to look for a .env file in the root of the repo

nöice, it works

Updates .gitignore to fix the path for the .quarto folder (which does need to be inside of site/)

not sure what this change does but it's there!

@nrichers nrichers merged commit e81bd24 into main May 9, 2024
@nrichers nrichers deleted the lets-try-this-again branch May 9, 2024 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

infrastructure Docs infra changes internal Not to be externalized in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.