Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Update _variables.yml#172

Merged
validbeck merged 2 commits intomainvalidmind/documentation:mainfrom
adding-variablesvalidmind/documentation:adding-variablesCopy head branch name to clipboard
Apr 23, 2024
Merged

Update _variables.yml#172
validbeck merged 2 commits intomainvalidmind/documentation:mainfrom
adding-variablesvalidmind/documentation:adding-variablesCopy head branch name to clipboard

Conversation

@validbeck
Copy link
Collaborator

Just popped some product variables into our YAML file!

(I used the GH website to make this pull request as I'm still a bit lost via the local way, oops)

Added `vm_platform` and `vm_framework` variables so they can called in the documentation
@validbeck validbeck added the internal Not to be externalized in the release notes label Apr 17, 2024
@validbeck validbeck self-assigned this Apr 17, 2024
Copy link
Collaborator

@nrichers nrichers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Kudos on finding your way to our Quarto variables file. 🚀

One question that kind of also relates to the glossary and style guide discussions we're having separately: what about short forms that aren't proper nouns, do we want to turn those into variables as well?

E.g. the short forms for the two variables you added are "developer framework" and "platform UI". The former is used quite often, the latter somewhat rarely.

We might also want to look into figuring out how to make it easier to use these variables with Quarto. One of the main reasons I didn't start using them for product names before is that they're a bit of a pain to use and there's no predictive typing at the moment. Perhaps having some product name snippets we make available for ourselves in VS Code might be helpful.

Added the shortforms for UI & framework
@validbeck
Copy link
Collaborator Author

One question that kind of also relates to the glossary and style guide discussions we're having separately: what about short forms that aren't proper nouns, do we want to turn those into variables as well?

E.g. the short forms for the two variables you added are "developer framework" and "platform UI". The former is used quite often, the latter somewhat rarely.

Great point, added the short forms as well.

We might also want to look into figuring out how to make it easier to use these variables with Quarto. One of the main reasons I didn't start using them for product names before is that they're a bit of a pain to use and there's no predictive typing at the moment.

Not quite sure how to do this independently, so let's chat about it!

@validbeck validbeck merged commit 5871c9d into main Apr 23, 2024
@nrichers nrichers deleted the adding-variables branch May 1, 2024 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal Not to be externalized in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.