ci: remove Node 6 testing #2609
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2609 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 114 114
Lines 2536 2536
Branches 642 642
=========================================
Hits 2536 2536 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This was referenced Oct 15, 2025
rubiin
approved these changes
Oct 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes Node 6 from the test because of dependency issues.
@babel/preset-envusesbrowerslistwhich usesbaseline-browser-mapping. The maintainer ofbaseline-browser-mappinghas indicated in web-platform-dx/baseline-browser-mapping#103 (comment) that Node 8 is the minimal supported version and targeting Node 6 is a bit of work.browerslistdoes support Node 6, but does not test on it becauseuvu(the test runner) does not support Node 6.Because of the history of this project, I would be hestitant in changing the build configuration without shipping a new major release (and dropping support for Node versions that are end of life). And since we support Node >=0.10 without testing until Node 6, I think it's fine if we remove testing for Node 6 as well.
To be clear; this does not change anything in our build or what Node versions we support, just in the way that we test changes.
Checklist