-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
feat(isBefore): allow usage of options object #2088
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(isBefore): allow usage of options object #2088
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2088 +/- ##
===========================================
- Coverage 100.00% 99.96% -0.04%
===========================================
Files 110 113 +3
Lines 2510 2531 +21
Branches 633 643 +10
===========================================
+ Hits 2510 2530 +20
- Partials 0 1 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few remarks, thanks for working on this!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few final comments so that this is consistent with my changes to isAfter
and the project in general, but apart from these we should be good I think
b4167b7
to
e907cde
Compare
I think this should be good to go :). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few remarks to be more in line with how isAfter
was done, but those should be my last
This PR implements steps 1 and 2 of #1874 for
isBefore
and builds upon #2075.This PR extracts tests for
isBefore
into a separate test file ⇾test/validators/isBefore.test.js
(inspired by #1793).This PR also renames the proposed
date
option tocomparisonDate
, because it is more explicit. If verified, it should be implemented in #2075 as well.Checklist