Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

do not check if the host is valid if no host is specified and not require_host #1995

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 17, 2022
Merged

do not check if the host is valid if no host is specified and not require_host #1995

merged 1 commit into from
Jul 17, 2022

Conversation

mortbauer
Copy link
Contributor

Fix the isURL check to not check the host if the host part is empty and require_host is false

This PR fixes isse #1994

Checklist

  • PR contains only changes related; no stray files, etc.
  • README updated (where applicable)
  • Tests written (where applicable)

@codecov
Copy link

codecov bot commented Jul 2, 2022

Codecov Report

Merging #1995 (5d2ff83) into master (37cbd5c) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master     #1995   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          103       103           
  Lines         2099      2101    +2     
  Branches       474       475    +1     
=========================================
+ Hits          2099      2101    +2
Impacted Files Coverage Δ
src/lib/isURL.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 37cbd5c...5d2ff83. Read the comment docs.

@rubiin rubiin merged commit 9f89f3b into validatorjs:master Jul 17, 2022
@pano9000 pano9000 mentioned this pull request Jan 23, 2023
Closed
@profnandaa profnandaa mentioned this pull request Feb 2, 2023
Closed
@rntvicente rntvicente mentioned this pull request May 24, 2024
Open
@sahilpawar58 sahilpawar58 mentioned this pull request May 25, 2024
Open
@ChinmoyHembram ChinmoyHembram mentioned this pull request May 25, 2024
Open
@wambugucoder wambugucoder mentioned this pull request May 30, 2024
Open
@rntvicente rntvicente mentioned this pull request May 30, 2024
Open
@DefenderK DefenderK mentioned this pull request May 30, 2024
Closed
@ChinmoyHembram ChinmoyHembram mentioned this pull request May 30, 2024
Open
@ceconcarlsen ceconcarlsen mentioned this pull request May 31, 2024
Open
@sumandas0 sumandas0 mentioned this pull request May 31, 2024
Open
This was referenced Jun 3, 2024
Closed
Closed
@DefenderK DefenderK mentioned this pull request Jun 7, 2024
Closed
@IT21275210 IT21275210 mentioned this pull request Jun 8, 2024
Open
@snyk-io snyk-io bot mentioned this pull request Jun 10, 2024
Closed
@florinMiro florinMiro mentioned this pull request Jun 11, 2024
Closed
@snyk-io snyk-io bot mentioned this pull request Jun 11, 2024
Closed
This was referenced Jun 12, 2024
Closed
Closed
@snyk-io snyk-io bot mentioned this pull request Jun 13, 2024
Closed
@DefenderK DefenderK mentioned this pull request Jun 13, 2024
Closed
This was referenced Jun 14, 2024
Closed
Closed
@DefenderK DefenderK mentioned this pull request Jun 14, 2024
Closed
@snyk-io snyk-io bot mentioned this pull request Jun 20, 2024
Closed
This was referenced Jun 21, 2024
Closed
Closed
This was referenced Jul 10, 2024
Closed
Closed
Closed
@rm-neilsondesa rm-neilsondesa mentioned this pull request Jul 16, 2024
Open
@snyk-io snyk-io bot mentioned this pull request Jul 18, 2024
Closed
@DefenderK DefenderK mentioned this pull request Jul 18, 2024
Closed
This was referenced Jul 19, 2024
Closed
Closed
Closed
@luizhp luizhp mentioned this pull request Aug 21, 2024
Open
This was referenced Aug 30, 2024
Open
Open
@sumandas0 sumandas0 mentioned this pull request Sep 8, 2024
Open
@TheJ-Erk400 TheJ-Erk400 mentioned this pull request Sep 8, 2024
Open
@Bastien-Durand Bastien-Durand mentioned this pull request Sep 9, 2024
Open
@KOTTAGENVH KOTTAGENVH mentioned this pull request Sep 27, 2024
Open
@DefenderK DefenderK mentioned this pull request Oct 30, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rubiin rubiin rubiin approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mortbauer @rubiin
Morty Proxy This is a proxified and sanitized view of the page, visit original site.