fix: isMobilePhone Regular Expression for Vietnamese phone number #1689
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
profnandaa
reviewed
Jul 16, 2021
Codecov Report
@@ Coverage Diff @@
## master #1689 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 101 101
Lines 1862 1862
=========================================
Hits 1862 1862
Continue to review full report at Codecov.
|
|
Fixed! @profnandaa |
profnandaa
approved these changes
Jul 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to this Vietnam phone number guide, we should accept 11 length phone numbers as valid when the number starts with the
84country code. In addition, I am adding the55area code.Closes #813
Checklist