refactor(isDate): add strictMode and prevent mixed delimiters #1402
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1402 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 95 95
Lines 1248 1257 +9
=========================================
+ Hits 1248 1257 +9
Continue to review full report at Codecov.
|
|
validator.isDate('2020-05-02', { format: 'YYYY/MM/DD', strictMode: true}); /// returns false
validator.isDate(new Date(), { format: 'YYYY/MM/DD', strictMode: true}); // returns false |
|
@tux-tn thanks for working on this. |
profnandaa
approved these changes
Sep 20, 2020
This was referenced Mar 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I made some changes to
isDateto allow for more flexibility.strictModeto enforce strict comparison between input and format. InstrictModeDate objects, inputs with a different delimiter or string format are disallowed.delimiterslistisDate(input, format)Checklist