Replace GetIsolate() by Isolate::GetCurrent()
#224
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GetIsolate() by Isolate::GetCurrent()
|
Thanks, LGTM |
victorgomes
pushed a commit
that referenced
this pull request
Sep 26, 2025
* via gemini: Replace GetIsolate by Isolate::GetCurrent() * Manual fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace any call to
Object::GetIsolate()byIsolate::GetCurrent().This does not change anything, as
Object::GetIsolate()is already implemented asIsolate::GetCurrent()under the hood.Medium term, some of the new calls could / should be replaced by passing an existing isolate pointer, which can be more efficient depending on usage patterns and the platform that we execute on.
One drive-by fix: Replace
linked_requests_data.As<Array>()bylinked_requests_data.As<Value>().As<Array>()to fix debug builds.