[test] Pass existing CppHeap to Isolate creation #212
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New V8 API expects a CppHeap to exist for the whole existence of an Isolate. Therefore the APIs for attaching and detaching a CppHeap get deprecated, and an existing CppHeap has to be passed to the isolate during isolate creation. This PR adjusts a test that passes an existing CppHeap too late to the isolate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New V8 API expects a CppHeap to exist for the whole existence of an Isolate. Therefore the APIs for attaching and detaching a CppHeap get deprecated, and an existing CppHeap has to be passed to the isolate during isolate creation. This PR adjusts a test that passes an existing CppHeap too late to the isolate.