Update GetForegroundTaskRunner calls #199
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pthier
pushed a commit
that referenced
this pull request
Oct 2, 2024
* Update GetForegroundTaskRunner calls * Format --------- Co-authored-by: Etienne Pierre-doray <etiennep@chromium.org>
victorgomes
pushed a commit
that referenced
this pull request
Nov 18, 2024
* Update GetForegroundTaskRunner calls * Format --------- Co-authored-by: Etienne Pierre-doray <etiennep@chromium.org>
billywhizz
pushed a commit
to billywhizz/node-ci
that referenced
this pull request
Dec 5, 2024
To include v8/node#198 v8/node#199 Bug: 361124432 Change-Id: I13131d146f0f45633a68a521b7e636dc940eb142 Reviewed-on: https://chromium-review.googlesource.com/c/v8/node-ci/+/5823557 Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by: Patrick Thier <pthier@chromium.org> Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
victorgomes
pushed a commit
that referenced
this pull request
Dec 18, 2024
* Update GetForegroundTaskRunner calls * Format --------- Co-authored-by: Etienne Pierre-doray <etiennep@chromium.org>
victorgomes
pushed a commit
that referenced
this pull request
Jan 20, 2025
* Update GetForegroundTaskRunner calls * Format --------- Co-authored-by: Etienne Pierre-doray <etiennep@chromium.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up on #198
This updates calls to NodePlatform, which now need to explicitly pass priority argument
to GetForegroundTaskRunner().