Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Print usage on stderr for coreutils and suppress broken pipe errors for cat. #7907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

fnordahl
Copy link

@fnordahl fnordahl commented May 9, 2025

Please review/merge commit by commit.

Copy link

GNU testsuite comparison:

Skip an intermittent issue tests/timeout/timeout (fails in this run but passes in the 'main' branch)

Scripts exist that may call one of the multi-binary entry points
with argument 0 set to some other value than the name of the entry
point.

One example is the Open vSwitch testsuite which makes use of
/bin/true as an argument to the bash builtin `exec` to check
whether it supports the '-a' argument [0].

In this situation coreutils will print usage on standard output,
which makes unnecessary noise.

Printing usage on standard error, which is customary for other
tools, allows the script to succeed.

0: https://github.com/openvswitch/ovs/blob/28064e9fa50d/tests/ovs-macros.at#L199
Signed-off-by: Frode Nordahl <fnordahl@ubuntu.com>
Copy link

GNU testsuite comparison:

Skipping an intermittent issue tests/misc/tee (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/timeout/timeout (passes in this run but fails in the 'main' branch)

At present, the `cat` command unexpectedly prints an error message
when it receives a broken pipe error.

As an example, there are many workflows that make use of `cat` and
`head` together to process only part of the data.  The `head`
command will stop reading after a configured number of bytes or
lines, subsequently exposing `cat` to a broken pipe condition.

Said workflows may fail when they unexpectedly get error messages
in their output.

Suppress broken pipe errors.

Signed-off-by: Frode Nordahl <fnordahl@ubuntu.com>
@fnordahl fnordahl marked this pull request as ready for review May 11, 2025 20:03
@sylvestre
Copy link
Contributor

Please split the two commits in 2 different pr

Copy link

GNU testsuite comparison:

Skipping an intermittent issue tests/timeout/timeout (passes in this run but fails in the 'main' branch)

@fnordahl
Copy link
Author

Split into #7920 and #7921 as requested by @sylvestre.

@fnordahl fnordahl closed this May 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.