Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

tests: Use #[should_panic] instead of #[ignore] where possible #7875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
Loading
from
Draft
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
tests: Use #[should_panic] instead of #[ignore]
  • Loading branch information
RenjiSann committed May 2, 2025
commit 6c437dcbe6886771ee8ffc9d7352c1aa6198b3d6
12 changes: 6 additions & 6 deletions 12 tests/by-util/test_expr.rs
Original file line number Diff line number Diff line change
Expand Up @@ -742,8 +742,8 @@ mod gnu_expr {
.stdout_only("3\n");
}

#[ignore]
#[test]
#[should_panic]
fn test_bre11() {
new_ucmd!()
.args(&["a$b", ":", "a$b"])
Expand Down Expand Up @@ -791,26 +791,26 @@ mod gnu_expr {
.stdout_only("\n");
}

#[ignore]
#[test]
#[should_panic]
fn test_bre17() {
new_ucmd!()
.args(&["{1}a", ":", "\\(\\{1\\}a\\)"])
.succeeds()
.stdout_only("{1}a\n");
}

#[ignore]
#[test]
#[should_panic]
fn test_bre18() {
new_ucmd!()
.args(&["X*", ":", "X\\(*\\)", ":", "^*"])
.succeeds()
.stdout_only("1\n");
}

#[ignore]
#[test]
#[should_panic]
fn test_bre19() {
new_ucmd!()
.args(&["{1}", ":", "\\{1\\}"])
Expand Down Expand Up @@ -1021,17 +1021,17 @@ mod gnu_expr {
.stderr_contains("Invalid content of \\{\\}");
}

#[ignore]
#[test]
#[should_panic]
fn test_bre45() {
new_ucmd!()
.args(&["a", ":", "a\\{,2\\}"])
.succeeds()
.stdout_only("1\n");
}

#[ignore]
#[test]
#[should_panic]
fn test_bre46() {
new_ucmd!()
.args(&["a", ":", "a\\{,\\}"])
Expand Down
Morty Proxy This is a proxified and sanitized view of the page, visit original site.