Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 9959632

Browse filesBrowse files
refactor, simplify
1 parent b1e7127 commit 9959632
Copy full SHA for 9959632

File tree

1 file changed

+20
-31
lines changed
Filter options

1 file changed

+20
-31
lines changed

‎sqldev/src/test/java/org/utplsql/sqldev/test/runner/UtplsqlRunnerTest.java

Copy file name to clipboardExpand all lines: sqldev/src/test/java/org/utplsql/sqldev/test/runner/UtplsqlRunnerTest.java
+20-31Lines changed: 20 additions & 31 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
package org.utplsql.sqldev.test.runner;
1717

1818
import java.sql.Connection;
19-
import java.util.Arrays;
19+
import java.util.Collections;
2020

2121
import org.junit.After;
2222
import org.junit.Assert;
@@ -118,23 +118,18 @@ public void teardown() {
118118
new CodeCoverageReporterTest().teardown();
119119
}
120120

121+
private Connection getNewConnection() {
122+
final SingleConnectionDataSource ds = new SingleConnectionDataSource();
123+
ds.setDriverClassName("oracle.jdbc.OracleDriver");
124+
ds.setUrl(dataSource.getUrl());
125+
ds.setUsername(dataSource.getUsername());
126+
ds.setPassword(dataSource.getPassword());
127+
return DatabaseTools.getConnection(ds);
128+
}
129+
121130
@Test
122131
public void runTestsWithMaxTime() {
123-
final SingleConnectionDataSource ds1 = new SingleConnectionDataSource();
124-
ds1.setDriverClassName("oracle.jdbc.OracleDriver");
125-
ds1.setUrl(dataSource.getUrl());
126-
ds1.setUsername(dataSource.getUsername());
127-
ds1.setPassword(dataSource.getPassword());
128-
final Connection producerConn = DatabaseTools.getConnection(ds1);
129-
130-
final SingleConnectionDataSource ds2 = new SingleConnectionDataSource();
131-
ds2.setDriverClassName("oracle.jdbc.OracleDriver");
132-
ds2.setUrl(dataSource.getUrl());
133-
ds2.setUsername(dataSource.getUsername());
134-
ds2.setPassword(dataSource.getPassword());
135-
final Connection consumerConn = DatabaseTools.getConnection(ds2);
136-
137-
UtplsqlRunner runner = new UtplsqlRunner(Arrays.asList(":a"), producerConn, consumerConn);
132+
UtplsqlRunner runner = new UtplsqlRunner(Collections.singletonList(":a"), getNewConnection(), getNewConnection());
138133
runner.runTestAsync();
139134

140135
SystemTools.waitForThread(runner.getProducerThread(), 200000);
@@ -146,21 +141,15 @@ public void runTestsWithMaxTime() {
146141

147142
@Test
148143
public void runTestsWithCodeCoverage() {
149-
final SingleConnectionDataSource ds1 = new SingleConnectionDataSource();
150-
ds1.setDriverClassName("oracle.jdbc.OracleDriver");
151-
ds1.setUrl(dataSource.getUrl());
152-
ds1.setUsername(dataSource.getUsername());
153-
ds1.setPassword(dataSource.getPassword());
154-
final Connection producerConn = DatabaseTools.getConnection(ds1);
155-
156-
final SingleConnectionDataSource ds2 = new SingleConnectionDataSource();
157-
ds2.setDriverClassName("oracle.jdbc.OracleDriver");
158-
ds2.setUrl(dataSource.getUrl());
159-
ds2.setUsername(dataSource.getUsername());
160-
ds2.setPassword(dataSource.getPassword());
161-
final Connection consumerConn = DatabaseTools.getConnection(ds2);
162-
163-
UtplsqlRunner runner = new UtplsqlRunner(Arrays.asList(":test_f"), null, null, null, producerConn, consumerConn);
144+
UtplsqlRunner runner = new UtplsqlRunner(Collections.singletonList(":test_f"), null, null, null, getNewConnection(), getNewConnection());
145+
runner.runTestAsync();
146+
147+
SystemTools.waitForThread(runner.getProducerThread(), 200000);
148+
SystemTools.waitForThread(runner.getConsumerThread(), 200000);
149+
SystemTools.sleep(4 * 1000);
150+
Assert.assertNotNull(runner);
151+
runner.dispose();
152+
}
164153
runner.runTestAsync();
165154

166155
SystemTools.waitForThread(runner.getProducerThread(), 200000);

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.