Adding DDL trigger to speedup framework start #901
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lwasylow
reviewed
Apr 12, 2019
docs/userguide/install.md
Outdated
| @@ -121,6 +121,8 @@ The uninstall process will **not** drop profiler tables, as they can potentially | ||
|
|
||
| It is up to DBA to maintain the storage of the profiler tables. | ||
|
|
||
| Additionally the user performing the installation must have a `ADMINISTER DATABASE TRIGGER` privilege. This is required for installation of trigger that is responsible for parsing annotations at at compile-time of a package. |
There was a problem hiding this comment.
I thought that trigger will be an optional to install ?
There was a problem hiding this comment.
Optionality is on a TO-DO list for this feature.
I wanted to have it reviewed.
lwasylow
reviewed
Apr 12, 2019
lwasylow
approved these changes
Apr 12, 2019
Some tests need to be fixed to disable trigger before testing Some tests need to be added to prove trigger is working
Disabled `-scc` flag in tests
11a2310 to
db8ef50
Compare
…r_for_annotations # Conflicts: # source/core/annotations/ut_annotation_manager.pkb # source/core/ut_suite_manager.pkb
Added disabling trigger on annotation parser tests.
Added additional tests for annotation management with / without trigger. Fixed code for situations when trigger gets added on pre-existing tests.
lwasylow
approved these changes
Jun 9, 2019
| limitations under the License. | ||
| */ | ||
|
|
||
| gc_check_object_name constant varchar2(128) := 'UT3_TRIGGER_ALIVE'; |
There was a problem hiding this comment.
Would that not be better to define in utils for example and refer to it via package constant in trigger and this package ? Its only called twice but one less line to maintain ?
There was a problem hiding this comment.
This needs to be removed as no longer used - thanks
Refactored install scripts to avoid duplication. Added check for `oracle_maintained` schema when firing DDL trigger.
Reorganized code to avoid problems with conditional compilation on 12.2 for triggers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for DDL trigger to build annotation cache.
The approach is resolving huge schema scanning issues.
With this, users have option to install with or without DDL trigger enabled.
Without trigger, each time tests are run, framework needs to check cache validity. This can take quite some time on huge database schema.
With trigger enabled, no source code scanning is needed. Cache is maintained by DDL statements themselves.
Resolves #631