Address too long identified in 11g.

Address flaky expression checker to be reworked.
utPLSQL · jgebal · Apr 28, 2023 · Mar 28, 2023 · Mar 28, 2023 · Mar 29, 2023
commit adbc76eb027f8425975b8277d4a10e2ec9ce7f7c
diff --git a/source/api/ut_runner.pkb b/source/api/ut_runner.pkb
@@ -95,11 +95,13 @@ create or replace package body ut_runner is
    ut_event_manager.trigger_event(ut_event_manager.gc_initialize);
    ut_event_manager.trigger_event(ut_event_manager.gc_debug, ut_run_info());

-    --Verify tag tag expression is valid
-    if regexp_like(l_tags,'[&|]{2,}|[!-]{2,}|[!-][&|]|[^-&|!]+[-!]|[-!|&][)]')
+    --TODO:Verify tag tag expression is valid
+    /*
+    if regexp_like(l_tags,'[&|]{2,}|[!-]{2,}|[!-][&|]|[^-&|!,]+[-!]|[-!|&][)]')
      or (regexp_count(l_tags,'\(') <> regexp_count(l_tags,'\)')) then
      raise_application_error(ut_utils.gc_invalid_tag_expression, 'Invalid Tag expression');
    end if;
+    */
    if a_random_test_order_seed is not null then
      l_random_test_order_seed  := a_random_test_order_seed;
    elsif a_random_test_order then

diff --git a/source/core/ut_suite_cache_manager.pkb b/source/core/ut_suite_cache_manager.pkb
@@ -270,7 +270,7 @@ create or replace package body ut_suite_cache_manager is
      l_tags := replace(replace_legacy_tag_notation(l_tags),' ');
    end if;
    l_tags := REGEXP_REPLACE(l_tags, 
-                      '(\(|\)|\||\!|\&)?([^|&!-]+)(\(|\)|\||\!|\&)?', 
+                      '(\(|\)|\||\!|\&)?([^|&!-()]+)(\(|\)|\||\!|\&)?', 
                      q'[\1q'<\2>' member of tags\3]');    
    --replace operands to XPath
    l_tags := REGEXP_REPLACE(l_tags, '\|',' or ');
@@ -310,23 +310,23 @@ with
    from suites_mv c where c.self_type in ('UT_TEST')
    and ]'||l_tags||q'[
  ),  
-  tests_with_tags_inherited_from_suite as (
+  tests_with_tags_inh_from_suite as (
   select c.id,c.self_type,c.path,c.tags multiset union distinct t.tags tags,c.object_owner
   from suites_mv c join suites_matching_expr t 
     on (c.path||'.' like t.path || '.%' /*all descendants and self*/ and c.object_owner = t.object_owner)
  ),
-  tests_with_tags_promoted_to_suites as (
+  tests_with_tags_prom_to_suite as (
    select c.id,c.self_type,c.path,c.tags multiset union distinct t.tags tags,c.object_owner
    from suites_mv c join tests_matching_expr t 
      on (t.path||'.' like c.path || '.%' /*all ancestors and self*/ and c.object_owner = t.object_owner)
  )
  select obj from suites_mv c,
    (select id,row_number() over (partition by id order by id) r_num from
      (select id
-      from tests_with_tags_promoted_to_suites tst
+      from tests_with_tags_prom_to_suite tst
      where ]'||l_tags||q'[        
      union all
-      select id from tests_with_tags_inherited_from_suite tst
+      select id from tests_with_tags_inh_from_suite tst
      where ]'||l_tags||q'[   
      )
    ) t where c.id = t.id and r_num = 1 ]';

diff --git a/source/core/ut_suite_cache_manager.pks b/source/core/ut_suite_cache_manager.pks
@@ -94,9 +94,6 @@ create or replace package ut_suite_cache_manager authid definer is
    a_package_name   varchar2,
    a_procedure_name varchar2
  ) return boolean;
-
-
-function create_where_filter(a_tags varchar2
-  ) return varchar2;
+
 end ut_suite_cache_manager;
 /