fix(react): update unhead context on initial <Head> render #534
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh thanks 🙌 I was just reviewing the code to see if we could drop the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
Resolves #532
❓ Type of change
📚 Description
During
<Head>component rendering,applyHeadChangeswas conditionally called based on theisBrowserflag. Instead, we now leverage the initial value ofuseRefto apply changes to the Unhead context and update it later using useEffect. This approach improves SSR compatibility without relying on environment-specific variables (e.g.isBrowser) and ensuresuseHead/<Head>calls execute in the correct order.The previous implementation (relying on
isBrowser) did not respect theuseHead/<Head>execution order.