Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 1dc94db

Browse filesBrowse files
fix: use RequestHeaderMap for TypedRequest (#74)
1 parent a428093 commit 1dc94db
Copy full SHA for 1dc94db

2 files changed

+4-4Lines changed: 4 additions & 4 deletions

File tree

Expand file treeCollapse file tree
Open diff view settings
Filter options
Expand file treeCollapse file tree
Open diff view settings
Collapse file

‎src/fetch.ts‎

Copy file name to clipboardExpand all lines: src/fetch.ts
+2-2Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import type { ResponseHeaderMap } from './http'
1+
import type { RequestHeaderMap, ResponseHeaderMap } from './http'
22

33
export interface TypedHeaders<TypedHeaderValues extends Record<string, string> | unknown> extends Omit<Headers, 'append' | 'delete' | 'get' | 'getSetCookie' | 'has' | 'set' | 'forEach'> {
44
/** [MDN Reference](https://developer.mozilla.org/docs/Web/API/Headers/append) */
@@ -30,7 +30,7 @@ export interface TypedResponse<Body = unknown, Headers extends Record<string, st
3030
headers: TypedHeaders<Headers>
3131
}
3232

33-
export interface TypedRequest<Body = unknown, Headers extends Record<string, string> | unknown = ResponseHeaderMap> extends Omit<Request, 'clone' | 'headers' | 'json'> {
33+
export interface TypedRequest<Body = unknown, Headers extends Record<string, string> | unknown = RequestHeaderMap> extends Omit<Request, 'clone' | 'headers' | 'json'> {
3434
clone: () => TypedRequest<Body, Headers>
3535
json: () => Promise<Body>
3636
headers: TypedHeaders<Headers>
Collapse file

‎test/typed-fetch.test-d.ts‎

Copy file name to clipboardExpand all lines: test/typed-fetch.test-d.ts
+2-2Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -203,7 +203,7 @@ describe('TypedRequest', () => {
203203
expectTypeOf<CreateUserRequest['json']>().returns.toEqualTypeOf<Promise<{ name: string, email: string }>>()
204204

205205
// clone() should return TypedRequest with same header type
206-
expectTypeOf<CreateUserRequest['clone']>().returns.toEqualTypeOf<TypedRequest<{ name: string, email: string }, ResponseHeaderMap>>()
206+
expectTypeOf<CreateUserRequest['clone']>().returns.toEqualTypeOf<TypedRequest<{ name: string, email: string }, RequestHeaderMap>>()
207207
})
208208

209209
it('should type request headers correctly', () => {
@@ -278,7 +278,7 @@ describe('TypedRequest', () => {
278278
type DefaultRequest = TypedRequest
279279

280280
expectTypeOf<DefaultRequest['json']>().returns.toEqualTypeOf<Promise<unknown>>()
281-
expectTypeOf<DefaultRequest['headers']>().toEqualTypeOf<TypedHeaders<ResponseHeaderMap>>()
281+
expectTypeOf<DefaultRequest['headers']>().toEqualTypeOf<TypedHeaders<RequestHeaderMap>>()
282282
})
283283

284284
it('should work with schema-defined request headers', () => {

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.