[sub pr: #100] Rename classes & refactor fork token handling flow#101
Draft
craftxbox wants to merge 5 commits intounitystation:NewFlowChangesunitystation/central-command:NewFlowChangesfrom
Draft
[sub pr: #100] Rename classes & refactor fork token handling flow#101craftxbox wants to merge 5 commits intounitystation:NewFlowChangesunitystation/central-command:NewFlowChangesfrom
craftxbox wants to merge 5 commits intounitystation:NewFlowChangesunitystation/central-command:NewFlowChangesfrom
Conversation
corp-0
reviewed
Aug 11, 2025
corp-0
reviewed
Aug 11, 2025
corp-0
reviewed
Aug 11, 2025
| """ | ||
|
|
||
| def has_permission(self, request, view): | ||
| auth_header = request.headers.get("Authorization") |
Member
There was a problem hiding this comment.
I imagine you didn't like the X-Character-Token header. I think it was good to keep them separated and so we always know what we are talking about
Author
There was a problem hiding this comment.
Maybe only a minor thing however there's reasons not to put secrets in headers other than Authorization: https://stackoverflow.com/a/43164958/3934270
corp-0
reviewed
Aug 11, 2025
…s not exist on a request
Author
|
tested as working from Postman |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attempts to follow most of the review feedback given aswell.