invariant reading for csv + internal simplifcation#18
Merged
H3idi-X merged 2 commits intounity3d-jp:dev/mainunity3d-jp/UnityChanSpringBone:dev/mainfrom Dec 25, 2021
cyriaca:parse-invariantsCopy head branch name to clipboard
Merged
invariant reading for csv + internal simplifcation#18H3idi-X merged 2 commits intounity3d-jp:dev/mainunity3d-jp/UnityChanSpringBone:dev/mainfrom cyriaca:parse-invariantsCopy head branch name to clipboard
H3idi-X merged 2 commits intounity3d-jp:dev/mainunity3d-jp/UnityChanSpringBone:dev/mainfrom
cyriaca:parse-invariantsCopy head branch name to clipboard
Conversation
-StringQueueObjectBuilder/TextRecordParsing Reading float data for CSV uses invariant culture (period as decimal separator) to ensure periods are used as decimal separator -UnityComponentStringListBuilder/StringQueueObjectBuilder: Simplified internal code using Where(del).First()/FirstOrDefault() to instead directly use delegate-consuming First/FirstOrDefault -TextRecordParsing: Adjusted a usage of a read-only collection in a method to be private class member -TypedStringToValueMap: replaced a ternary operator with null-coalescing -SaveSpringBoneSetupWindow: removed unused using directive
|
|
Contributor
|
Apologies for this late replay. We didn't have time to see your pull request because of preparation for Siggraph Asia 2021 and so on. I started to check this. |
Contributor
Author
|
Hello. Thank you for checking. I would like to add, with sincere apologies, I did miss a part in that first commit. I forgot to push the remaining part. I have done so now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fundamentally this is #17 (each fixes #16) but with additions
TextRecordParsingfor consistencyGetMethod(which in context works on all relevant typesIsPrimitivebesidesIntPtr/UIntPtr) instead ofGetMethodswith LINQTryParsewith overloads instead of a new helper functionThere are also a few unrelated internal changes listed below.
Changed
Changed (minor / semantic)