Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Add conditional localization import#10

Merged
H3idi-X merged 3 commits intounity3d-jp:dev/mainunity3d-jp/UnityChanSpringBone:dev/mainfrom
cyriaca:dev/l10nCopy head branch name to clipboard
Oct 15, 2021
Merged

Add conditional localization import#10
H3idi-X merged 3 commits intounity3d-jp:dev/mainunity3d-jp/UnityChanSpringBone:dev/mainfrom
cyriaca:dev/l10nCopy head branch name to clipboard

Conversation

@riina
Copy link
Contributor

@riina riina commented Apr 9, 2021

Localization API moved in 2020.1 and 2020.2, so package has to be embedded/edited with these changes to work. Tested to work in 2020.3/2021.1.

UnityEditor.Localization.Editor.Localization moved to UnityEditor.L10n in 2020.2 (missing in 2020.1)

UnityEditor.Localization.Editor.LocalizationAttribute moved to UnityEditor.LocalizationAttribute in 2020.1

riina added 3 commits April 8, 2021 23:47
Localization API moved in 2020.1 and 2020.2
Technically based off 1.2.1-preview, but package manifest originally listed 1.2.0-preview
@H3idi-X H3idi-X merged commit 386ed22 into unity3d-jp:dev/main Oct 15, 2021
@H3idi-X
Copy link
Contributor

H3idi-X commented Oct 15, 2021

Apology for kept you waiting so long. We've checked Unity 2019.4 to 2021.2 and everything is fine, so I accept this PR. The version number and other contents of CHANGELOG.md will be changed later. Thank you for your cooperation.

@riina riina deleted the dev/l10n branch October 16, 2021 05:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments

Close sidebar
Morty Proxy This is a proxified and sanitized view of the page, visit original site.