Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

make_trade for v3 sends to 0x0 recipient #120

ToposFinance started this conversation in General
Discussion options

hello, when you drill down to the final function that is called when ETH is first token, it seems you have hardcoated in a recipient address.

You must be logged in to vote

Replies: 1 comment · 1 reply

Comment options

Holy shit, no idea how I could let this slip! Thanks for letting me know!

Fixed in 371eb84

Also published a new release (0.5.2) to PyPI which contains the fix.

You must be logged in to vote
1 reply
@ToposFinance
Comment options

thanks. it was an expensive lesson for me...;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.