Report protein match overflow explicitely#1842
Open
pverscha wants to merge 3 commits intodevelopunipept/unipept:developfrom
feature/report-cutoff-usedunipept/unipept:feature/report-cutoff-usedCopy head branch name to clipboard
Open
Report protein match overflow explicitely#1842pverscha wants to merge 3 commits intodevelopunipept/unipept:developfrom feature/report-cutoff-usedunipept/unipept:feature/report-cutoff-usedCopy head branch name to clipboard
pverscha wants to merge 3 commits intodevelopunipept/unipept:developfrom
feature/report-cutoff-usedunipept/unipept:feature/report-cutoff-usedCopy head branch name to clipboard
Conversation
tibvdm
requested changes
May 7, 2026
Contributor
tibvdm
left a comment
There was a problem hiding this comment.
The feature seems to work and I was able to input older projects to test the upgrader. I left some small remarks on the code
|
|
||
| for (const [peptide, old] of oldMap) { | ||
| const response = old.toPeptideDataResponse(); | ||
| response.cutoff_used = response.fa.counts.all > 9000; |
Contributor
There was a problem hiding this comment.
Where does this 9.000 come from? The cutoff value usually is 10.000 so I'm confused
| return lin; | ||
| } | ||
|
|
||
| public get ec(): any { |
Contributor
There was a problem hiding this comment.
It probably does not matter that much, but maybe this can be correctly typed. Looks like Record<string, number>
| return value === -1 ? "-" : value.toString(); | ||
| } | ||
|
|
||
| public get go(): any { |
| return output; | ||
| } | ||
|
|
||
| public get ipr(): any { |
| } | ||
| } | ||
|
|
||
| const updatedMetadata = JSON.parse(await metadataFile.async("string")); |
Contributor
There was a problem hiding this comment.
Metadata is already parsed above the loop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR provides a fix for #1839. Instead of hiding that a peptide's matches were cutoff, this is now explicitly reported to the user in both the "single peptide analysis" and "metaproteomics peptide analysis".
An alert is shown in the summary of the single peptide analysis. For the metaproteomics analysis, I have added an extra column to the analysis summary table. There is also a tooltip that's shown when the user hovers over the icons in this column which explains what this match exceeded means.
Screenshot for SPA:
Screenshot for MPA:
