Fix totalPeptides field in old projects in browser memory inaccessible#1770
Merged
pverscha merged 1 commit intodevelopunipept/unipept:developfrom Jan 21, 2026
fix/no-total-peptides-fieldunipept/unipept:fix/no-total-peptides-fieldCopy head branch name to clipboard
Merged
Fix totalPeptides field in old projects in browser memory inaccessible#1770pverscha merged 1 commit intodevelopunipept/unipept:developfrom fix/no-total-peptides-fieldunipept/unipept:fix/no-total-peptides-fieldCopy head branch name to clipboard
pverscha merged 1 commit intodevelopunipept/unipept:developfrom
fix/no-total-peptides-fieldunipept/unipept:fix/no-total-peptides-fieldCopy head branch name to clipboard
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Projects that are stored in the browser's IndexedDB and that have been made some time ago where missing the
totalPeptidesfield. This field, however, was expected to be there when loading in the project's metadata, causing Unipept to crash.This PR fixes this issue by using
0 peptidesas a placeholder when thetotalPeptidesfield is non-existing. The total peptides count will be correct the next time this project is opened again in Unipept.