Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 743998d

Browse filesBrowse files
committed
ICU-22977 Temp fix for MSVC builds: SkipUWP
1 parent f55c499 commit 743998d
Copy full SHA for 743998d

File tree

Expand file treeCollapse file tree

2 files changed

+6
-6
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

2 files changed

+6
-6
lines changed
Open diff view settings
Collapse file

‎.github/workflows/icu4c.yml‎

Copy file name to clipboardExpand all lines: .github/workflows/icu4c.yml
+4-4Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -383,10 +383,10 @@ jobs:
383383
uses: microsoft/setup-msbuild@v2
384384
- name: Build Solution x64
385385
if: contains(matrix.test_flags, 'arm Release')
386-
run: msbuild icu4c/source/allinone/allinone.sln /p:Configuration=Release /p:Platform=x64
386+
run: msbuild icu4c/source/allinone/allinone.sln /p:Configuration=Release /p:Platform=x64 /p:SkipUWP=true
387387
- name: Build Solution
388388
run: |
389-
msbuild icu4c/source/allinone/allinone.sln ${{ matrix.build_flags }}
389+
msbuild icu4c/source/allinone/allinone.sln ${{ matrix.build_flags }} /p:SkipUWP=true
390390
- name: Run ${{ matrix.test_flags }} Tests (icucheck.bat)
391391
if: contains(matrix.test_flags, 'arm Release') == false
392392
run: |
@@ -433,9 +433,9 @@ jobs:
433433
uses: microsoft/setup-msbuild@v2
434434
- name: Build Solution x64
435435
if: contains(matrix.win_ver, 'ARM64')
436-
run: msbuild icu4c/source/allinone/allinone.sln /p:Configuration=Release /p:Platform=x64
436+
run: msbuild icu4c/source/allinone/allinone.sln /p:Configuration=Release /p:Platform=x64 /p:SkipUWP=true
437437
- name: Build Solution
438-
run: msbuild icu4c/source/allinone/allinone.sln /p:Configuration=Release /p:Platform=${{ matrix.plat }}
438+
run: msbuild icu4c/source/allinone/allinone.sln /p:Configuration=Release /p:Platform=${{ matrix.plat }} /p:SkipUWP=true
439439
- name: Run Tests (icucheck.bat)
440440
if: contains(matrix.win_ver, 'ARM64') == false
441441
run: icu4c/source/allinone/icucheck.bat ${{ matrix.arch }} Release
Collapse file

‎.github/workflows/icu_merge_ci.yml‎

Copy file name to clipboardExpand all lines: .github/workflows/icu_merge_ci.yml
+2-2Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -843,11 +843,11 @@ jobs:
843843
- name: Set up MSBuild
844844
uses: microsoft/setup-msbuild@v2
845845
- name: Build Solution
846-
run: msbuild icu4c/source/allinone/allinone.sln /p:Configuration=${{ matrix.config }} /p:Platform=${{ matrix.platform }}
846+
run: msbuild icu4c/source/allinone/allinone.sln /p:Configuration=${{ matrix.config }} /p:Platform=${{ matrix.platform }} /p:SkipUWP=true
847847
- name: Run Tests (icucheck.bat)
848848
run: icu4c/source/allinone/icucheck.bat ${{ matrix.arch }} ${{ matrix.config }}
849849
- name: Build Sample Solution
850-
run: msbuild icu4c/source/samples/all/all.sln /p:Configuration=${{ matrix.config }} /p:Platform=${{ matrix.arch }}
850+
run: msbuild icu4c/source/samples/all/all.sln /p:Configuration=${{ matrix.config }} /p:Platform=${{ matrix.arch }} /p:SkipUWP=true
851851
- name: Test Samples (samplecheck.bat)
852852
run: icu4c/source/samples/all/samplecheck.bat ${{ matrix.arch }} ${{ matrix.config }}
853853

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.